Issue 8613 in angleproject: GL: Anonymous varying structs cannot be declared together

1 view
Skip to first unread message

kkinn… via monorail

unread,
Mar 15, 2024, 9:31:15 AM3/15/24
to angleproj...@googlegroups.com
Updates:
Summary: GL: Anonymous varying structs cannot be declared together

Comment #1 on issue 8613 by kkinn...@apple.com: GL: Anonymous varying structs cannot be declared together
https://bugs.chromium.org/p/angleproject/issues/detail?id=8613#c1

(No comment was entered for this change.)

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

k… via monorail

unread,
Mar 15, 2024, 1:26:11 PM3/15/24
to angleproj...@googlegroups.com
Updates:
Blockedon: 8590

Comment #2 on issue 8613 by k...@chromium.org: GL: Anonymous varying structs cannot be declared together
https://bugs.chromium.org/p/angleproject/issues/detail?id=8613#c2

k… via monorail

unread,
Mar 15, 2024, 1:26:52 PM3/15/24
to angleproj...@googlegroups.com

Comment #3 on issue 8613 by k...@chromium.org: GL: Anonymous varying structs cannot be declared together
https://bugs.chromium.org/p/angleproject/issues/detail?id=8613#c3

See also https://chromium-review.googlesource.com/c/angle/angle/+/5372727 , where the expectations referencing this bug are introduced.

kkinn… via monorail

unread,
May 14, 2024, 4:52:35 AM5/14/24
to angleproj...@googlegroups.com

Comment #4 on issue 8613 by kkinn...@apple.com: GL: Anonymous varying structs cannot be declared together
https://bugs.chromium.org/p/angleproject/issues/detail?id=8613#c4

There are two problems:

p1: Some of the rewrite phases inspect the symbol table for the variable names. IIRC this was at least the case for output variables phase.
This is obviously incorrect, as the symbol table is not updated during previous rewrite steps. Thus the symbol table will contain variables with wrong structure information, structures of which the declarations do not exist in the tree anymore.


p2: Separated anonymous output stucts do not get unique name.
https://github.com/KhronosGroup/WebGL/issues/3656
Reply all
Reply to author
Forward
0 new messages