Issue 8555 in angleproject: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil

[d… via monorail]

Status: Available
Owner: ----
OS: Mac
Priority: Medium
Type: Defect

New issue 8555 by d...@apple.com: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555

Configure ANGLE build with the following settings via `gn args`

```
# Set build arguments here. See `gn help buildargs`.
angle_assert_always_on = true
angle_build_vulkan_system_info = false
angle_enable_metal = true
angle_enable_vulkan = false
angle_extract_native_libs = true
angle_enable_trace = true
angle_enable_trace_events = true
is_component_build = false
enable_dsyms = true
is_debug = true
is_official_build = false
strip_debug_info = false
symbol_level = 2
```

Build with `autoninja -C out/Debug`, results in build failure due to duplicate linking of `abseil` via `ANGLE` and `dawn`. For example:

```
ld64.lld: error: duplicate symbol: absl::base_internal::NominalCPUFrequency()
>>> defined in sysinfo.cc:377 (../../third_party/abseil-cpp/absl/base/internal/sysinfo.cc:377)
>>> obj/third_party/abseil-cpp/absl/base/base/sysinfo.o
>>> defined in sysinfo.cc:365 (../../third_party/abseil-cpp/absl/base/internal/sysinfo.cc:365)
>>> obj/third_party/dawn/third_party/gn/abseil-cpp/base/sysinfo.o
```

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[d… via monorail]

Comment #1 on issue 8555 by d...@apple.com: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c1

As a work around, disabling `wpgu` by adding:
```
angle_enable_wgpu = false
```
via `gn args` enables a clean build for me

[syous… via monorail]

Updates:
Owner: l...@chromium.org

Comment #2 on issue 8555 by syou...@chromium.org: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c2

Thank you for the report. This is a known issue with `is_component_build = false`.

Assigning to Liza.

[d… via monorail]

Comment #3 on issue 8555 by d...@apple.com: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c3

I'm sure I got `is_component_build = false` from the ANGLE build documentation. Should I remove it?

[syous… via monorail]

Comment #4 on issue 8555 by syou...@chromium.org: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c4

No that option is good, it's just a very recent webgpu development that has broken this build. We're working on a fix, and in the meantime `angle_enable_wgpu = false` is the recommended option.

[Git Watcher via monorail]

Comment #5 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c1fe0305dd61f2bfe49b9a35db4d4bf44a7a20e4

commit c1fe0305dd61f2bfe49b9a35db4d4bf44a7a20e4
Author: Danil Chapovalov <dani...@chromium.org>
Date: Tue Mar 05 13:51:19 2024

Don't build absl tests unless build_with_chromium is set

This would allow projects like angle/dawn to reuse BUILD.gn without adding dependency on chromium's //third_party/googletest

Bug: angleproject:8555
Change-Id: I654fa2257bc0b4ce275f08daf7bf33e262a4b38f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340459
Commit-Queue: Danil Chapovalov <dani...@chromium.org>
Reviewed-by: Geoff Lang <geof...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1268415}

[modify] https://crrev.com/c1fe0305dd61f2bfe49b9a35db4d4bf44a7a20e4/third_party/abseil-cpp/BUILD.gn
[modify] https://crrev.com/c1fe0305dd61f2bfe49b9a35db4d4bf44a7a20e4/third_party/abseil-cpp/absl.gni

[Git Watcher via monorail]

Comment #6 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c6

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/86014ef1208b8cea672a5953d1f0157c50f9d8d2

commit 86014ef1208b8cea672a5953d1f0157c50f9d8d2
Author: Geoff Lang <geof...@chromium.org>
Date: Wed Mar 06 20:34:24 2024

Disable abseil warnings for non-chromium builds.

Dawn uses abseil's enable_if which needs additional warning
suppressions.

Bug: angleproject:8555
Change-Id: I620a4ef68dc5328e5d8309f32e2f6a23140c5ea5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5344213
Reviewed-by: Mirko Bonadei <mbon...@chromium.org>
Commit-Queue: Geoff Lang <geof...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1269201}

[modify] https://crrev.com/86014ef1208b8cea672a5953d1f0157c50f9d8d2/third_party/abseil-cpp/BUILD.gn
[modify] https://crrev.com/86014ef1208b8cea672a5953d1f0157c50f9d8d2/third_party/abseil-cpp/absl.gni

[Git Watcher via monorail]

Comment #7 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c7

The following revision refers to this bug:

https://chromium.googlesource.com/angle/angle/+/dcc79a2764ec4b24295f63877e5bcf645fd7ffca

commit dcc79a2764ec4b24295f63877e5bcf645fd7ffca
Author: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Date: Thu Mar 07 08:16:07 2024

Roll Chromium from 632158ced47e to 15a5ccdeffb7 (1166 revisions)

https://chromium.googlesource.com/chromium/src.git/+log/632158ced47e..15a5ccdeffb7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC angle...@google.com,cnor...@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Chromium:
https://bugs.chromium.org/p/chromium/issues/entry
To file a bug in ANGLE:
https://bugs.chromium.org/p/angleproject/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/44a09aad28..13b8fee160
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/d713d42ccb..3aee14bc7f
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/27e93a3038..2b09b9df51
* third_party/android_sdk/public: BRpfUGFd3WoveSGTLVgkQF7ugIVyywGneVICP4c0010C..mU9jm4LkManzjSzRquV1UIA7fHBZ2pK7NtbCXxoVnVUC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/04e0eca1d6..dce5ffc5d2
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/771b8d7983..1382a3f980
* third_party/fuchsia-sdk/sdk: version:18.20240227.3.1..version:19.20240305.3.1
* third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/204deaa9c5..fc6253a642
* third_party/r8: aTcfsTzfQ91mQC4U3TNlty5drvFxN2waTua1WS8aZqIC..pPC714UT8JI_keEmKczVDVj3j-64VCZGe0e1ZQuNkzwC
* third_party/siso: git_revision:8632c71c8cadd9cb9ea4d43e6b30eeae4dffcd12..git_revision:86b0e81fba4005098b1bec9ca40018fc3dacd523
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/77a2b7ff01..4b8c861695
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/0118c99445..7eeec100fa
* tools/luci-go: git_revision:3df60a11d33a59614c0e8d2bccc58d8c30984901..git_revision:47b2cf1a0385b9802fd16640ed6503dcd9b0968d
* tools/luci-go: git_revision:3df60a11d33a59614c0e8d2bccc58d8c30984901..git_revision:47b2cf1a0385b9802fd16640ed6503dcd9b0968d
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b2f436cdad..443a96da58
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/4753a8cbcd..25e18b2750
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/053067cf26..fe6d3d4250
* tools/skia_goldctl/linux: zK5gXUdYtOJO_5L0VqpL13_iPtatoApMRsbAJ-AObycC..yquIc29kBas8oAZe6wPO9ZNGPVY4AjmNosbCqa9sbXQC
* tools/skia_goldctl/mac_amd64: I77LRdzh6aOopDPydG6LuPfDh6BbH4IFqWH8WWesWlMC..SqXfMDAV003pwRx5sa-VSGN0lp4Og_P4DlHUV54f8roC
* tools/skia_goldctl/mac_arm64: JRekXzEdC8R2yKoqGJvHhZ516qC1pJwyHAxOuqTyDREC..55xq4Xmk5RkSUrN9JmaoJicHNHq3CEvyUGUYpIYWgzkC
* tools/skia_goldctl/win: fWJiw3sBoMGqR2SS2otkCsOmnqK4iXZUWzTVfqw0cssC..za3RHr_K-guiGt-84l7HPODPSiYSf0r6PurVZ5AKGMwC
No update to Clang.

Bug: angleproject:8555
Tbr: cnor...@google.com
Change-Id: I13ca3fd2e13447f96df78af7cff95d677a612b58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5351463
Commit-Queue: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-a...@skia-public.iam.gserviceaccount.com>

[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/tools/perf
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/third_party/depot_tools
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/tools/mb
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/testing
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/third_party/abseil-cpp
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/third_party/libc++abi/src
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/infra/specs/mixins.pyl
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/tools/android
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/build
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/third_party/catapult
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/tools/clang
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/DEPS
[modify] https://crrev.com/dcc79a2764ec4b24295f63877e5bcf645fd7ffca/tools/memory

[Git Watcher via monorail]

Comment #8 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c8

The following revision refers to this bug:

https://dawn.googlesource.com/dawn/+/2ce42fc95ab7cf7bbf97a9c48876c67c95f9cb78

commit 2ce42fc95ab7cf7bbf97a9c48876c67c95f9cb78
Author: Geoff Lang <geof...@google.com>
Date: Tue Mar 12 22:31:50 2024

Use abseil's build targets instead of custom ones.

Chromium's abseil has been updated to no longer depend on external
build files like googletest. The required warning suppressions for dawn
have also been added.

Bug: angleproject:8555
Change-Id: I9e590dd26301a5e8f5d670180bebc751a22ea052
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/178940
Kokoro: Kokoro <noreply+kok...@google.com>
Reviewed-by: Austin Eng <en...@chromium.org>
Commit-Queue: Geoff Lang <geof...@google.com>
Reviewed-by: Corentin Wallez <cwa...@chromium.org>

[modify] https://dawn.googlesource.com/dawn/+/2ce42fc95ab7cf7bbf97a9c48876c67c95f9cb78/third_party/abseil-cpp
[modify] https://dawn.googlesource.com/dawn/+/2ce42fc95ab7cf7bbf97a9c48876c67c95f9cb78/src/dawn/wire/BUILD.gn
[modify] https://dawn.googlesource.com/dawn/+/2ce42fc95ab7cf7bbf97a9c48876c67c95f9cb78/DEPS
[modify] https://dawn.googlesource.com/dawn/+/2ce42fc95ab7cf7bbf97a9c48876c67c95f9cb78/src/dawn/native/BUILD.gn
[modify] https://dawn.googlesource.com/dawn/+/2ce42fc95ab7cf7bbf97a9c48876c67c95f9cb78/src/tint/BUILD.gn
[delete] https://dawn.googlesource.com/dawn/+/bac513d0ae286600ea0f75a75223a5b52a198b9b/third_party/gn/abseil-cpp/BUILD.gn

[Git Watcher via monorail]

Comment #9 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c9

The following revision refers to this bug:

https://dawn.googlesource.com/dawn/+/29b75b83730ce94abbb603f7dd4c0afbadf21192

commit 29b75b83730ce94abbb603f7dd4c0afbadf21192
Author: Geoff Lang <geof...@google.com>
Date: Fri Mar 15 15:37:07 2024

Revert "Use abseil's build targets instead of custom ones."

This reverts commit 2ce42fc95ab7cf7bbf97a9c48876c67c95f9cb78.

Reason for revert: Can't roll into Skia due to old toolchains on Mac

Original change's description:

> Use abseil's build targets instead of custom ones.
>
> Chromium's abseil has been updated to no longer depend on external
> build files like googletest. The required warning suppressions for dawn
> have also been added.
>
> Bug: angleproject:8555
> Change-Id: I9e590dd26301a5e8f5d670180bebc751a22ea052
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/178940
> Kokoro: Kokoro <noreply+kok...@google.com>
> Reviewed-by: Austin Eng <en...@chromium.org>
> Commit-Queue: Geoff Lang <geof...@google.com>
> Reviewed-by: Corentin Wallez <cwa...@chromium.org>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:8555
Change-Id: I64b4809f7d3b7f3ad1802aac11461be3960be55c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/179144
Kokoro: Kokoro <noreply+kok...@google.com>

Commit-Queue: Geoff Lang <geof...@google.com>
Reviewed-by: Corentin Wallez <cwa...@chromium.org>

Reviewed-by: Florin Malita <fma...@chromium.org>

[modify] https://dawn.googlesource.com/dawn/+/29b75b83730ce94abbb603f7dd4c0afbadf21192/third_party/abseil-cpp
[modify] https://dawn.googlesource.com/dawn/+/29b75b83730ce94abbb603f7dd4c0afbadf21192/src/dawn/wire/BUILD.gn
[modify] https://dawn.googlesource.com/dawn/+/29b75b83730ce94abbb603f7dd4c0afbadf21192/DEPS
[modify] https://dawn.googlesource.com/dawn/+/29b75b83730ce94abbb603f7dd4c0afbadf21192/src/dawn/native/BUILD.gn
[modify] https://dawn.googlesource.com/dawn/+/29b75b83730ce94abbb603f7dd4c0afbadf21192/src/tint/BUILD.gn
[add] https://dawn.googlesource.com/dawn/+/29b75b83730ce94abbb603f7dd4c0afbadf21192/third_party/gn/abseil-cpp/BUILD.gn

[Git Watcher via monorail]

Comment #10 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c10

The following revision refers to this bug:

https://chromium.googlesource.com/angle/angle/+/f4ecbe6f136a1b99b2aef5ac129d2b9653abe190

commit f4ecbe6f136a1b99b2aef5ac129d2b9653abe190
Author: Geoff Lang <geof...@chromium.org>
Date: Thu Mar 14 17:31:20 2024

Use Dawn's abseil build files when wgpu is enabled.

To avoid building abseil with multiple different build files, use
dawn's build files when it is available.

Also use dawn's build files for out-of-chromium component builds to
match dawn's conditions.

Bug: angleproject:8555
Change-Id: I10c1578630dafa14fdd118feb66790eb0bf27792
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5371323
Commit-Queue: Geoff Lang <geof...@chromium.org>
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
Reviewed-by: Liza Burakova <li...@chromium.org>

[modify] https://crrev.com/f4ecbe6f136a1b99b2aef5ac129d2b9653abe190/BUILD.gn

[Git Watcher via monorail]

Comment #11 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c11

The following revision refers to this bug:

https://chromium.googlesource.com/angle/angle/+/21b5c321138752ae6e1e4d93cfa5b78c39250f52

commit 21b5c321138752ae6e1e4d93cfa5b78c39250f52
Author: Geoff Lang <geof...@chromium.org>
Date: Tue Mar 19 21:12:42 2024

Pin abseil-cpp until Skia is able to build with ToT abseil.

Currently ANGLE uses Dawn's abseil buildfiles when building standalone
with Dawn enabled. If abseil changes, Dawn's buildfiles no longer work
with the version that ANGLE checks out. Dawn is also stuck using a
older version of abseil until https://skbug.com/330350366 is resolved.

Once https://skbug.com/330350366 resolves, Dawn can use the build files
in abseil-cpp and all projects can roll abseil independently and still
have it build.

Bug: angleproject:8555
Change-Id: Iad1e8618117b7dbfa713cbe1ccbff1cc8e4d93f8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5381480
Reviewed-by: Roman Lavrov <rom...@google.com>
Commit-Queue: Geoff Lang <geof...@chromium.org>

[modify] https://crrev.com/21b5c321138752ae6e1e4d93cfa5b78c39250f52/scripts/roll_chromium_deps.py

[Git Watcher via monorail]

Comment #12 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c12

The following revision refers to this bug:

https://chromium.googlesource.com/angle/angle/+/a69c56fa884e6f70f061a2f9c8137e7d4570516a

commit a69c56fa884e6f70f061a2f9c8137e7d4570516a
Author: Yuly Novikov <ynov...@chromium.org>
Date: Thu Mar 21 16:45:11 2024

Pin build until Skia is able to build with ToT abseil.

ANGLE pins abseil-cpp until https://skbug.com/330350366 is resolved.
Therefore ANGLE's abseil-cpp uses old DEF files, which can't be kept in
sync with new build, e.g. Win toolchain updates.

Bug: angleproject:8555
Change-Id: Ie5a8a1bb8b4286dfcf50b73cddd36b05bf1c5b15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5385782
Auto-Submit: Yuly Novikov <ynov...@chromium.org>
Commit-Queue: Roman Lavrov <rom...@google.com>
Reviewed-by: Roman Lavrov <rom...@google.com>

[modify] https://crrev.com/a69c56fa884e6f70f061a2f9c8137e7d4570516a/scripts/roll_chromium_deps.py

[Git Watcher via monorail]

Comment #13 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c13

The following revision refers to this bug:

https://chromium.googlesource.com/angle/angle/+/1d5991d903c24f2c83edc4377a51d62983149c29

commit 1d5991d903c24f2c83edc4377a51d62983149c29
Author: Yuly Novikov <ynov...@chromium.org>
Date: Tue Mar 26 16:36:23 2024

Pin libc++ until Skia is able to build with ToT abseil.

ANGLE pins abseil-cpp until https://skbug.com/330350366 is resolved.
Therefore ANGLE's abseil-cpp uses old DEF files, which can't be kept in

sync with new libc++, e.g. here:
https://chromium-review.googlesource.com/c/angle/angle/+/5391204/1

Bug: angleproject:8555
Change-Id: Ib61a80136e389ffbd67c7c378a5c8d9c2659be55
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5397577
Commit-Queue: Yuly Novikov <ynov...@chromium.org>
Reviewed-by: Solti Ho <so...@google.com>
Commit-Queue: Solti Ho <so...@google.com>
Reviewed-by: Yuxin Hu <yux...@google.com>
Auto-Submit: Yuly Novikov <ynov...@chromium.org>
Commit-Queue: Yuxin Hu <yux...@google.com>

[modify] https://crrev.com/1d5991d903c24f2c83edc4377a51d62983149c29/scripts/roll_chromium_deps.py

[Git Watcher via monorail]

Comment #14 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c14

The following revision refers to this bug:

https://chromium.googlesource.com/angle/angle/+/93b45da9bfb6940e18766480824147a93eac8fbd

commit 93b45da9bfb6940e18766480824147a93eac8fbd
Author: Yuly Novikov <ynov...@chromium.org>
Date: Fri Mar 29 12:44:00 2024

Pin clang until Skia is able to build with ToT abseil.

ANGLE pins abseil-cpp until https://skbug.com/330350366 is resolved.
Therefore ANGLE's abseil-cpp uses old DEF files, which can't be kept in

sync with new clang, e.g. here:
https://chromium-review.googlesource.com/c/angle/angle/+/5406623
which includes DEF file updates in
https://chromium-review.googlesource.com/c/chromium/src/+/5405904

Bug: angleproject:8555
Change-Id: Iac06d456aadaf2b3dd08a943a46d710ee25887d4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5401708
Auto-Submit: Yuly Novikov <ynov...@chromium.org>
Commit-Queue: Solti Ho <so...@google.com>
Reviewed-by: Solti Ho <so...@google.com>

[modify] https://crrev.com/93b45da9bfb6940e18766480824147a93eac8fbd/scripts/roll_chromium_deps.py

[Git Watcher via monorail]

Comment #15 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c15

The following revision refers to this bug:

https://chromium.googlesource.com/angle/angle/+/5f532b75c296286ebf4eb404096cd5f9e533a890

commit 5f532b75c296286ebf4eb404096cd5f9e533a890
Author: Yuly Novikov <ynov...@chromium.org>
Date: Thu Apr 18 09:19:23 2024

Roll chromium_revision 0abb3a90f2..b07526b70d (1287851:1289209)

Unpin abseil-cpp and related DEPS,
since Mac Skia bots older than macOS 10.15 were removed,
so ANGLE can update abseil-cpp now without breaking roll into Skia.

Roll third_party/dawn/ 66f38fda8..ed2c7c713 (212 commits; 6 trivial rolls)
https://dawn.googlesource.com/dawn.git/+log/66f38fda85fe..ed2c7c7133fd
in order to fix build with updated Clang,
https://dawn-review.googlesource.com/c/dawn/+/182582

Change log: https://chromium.googlesource.com/chromium/src/+log/0abb3a90f2..b07526b70d
Full diff: https://chromium.googlesource.com/chromium/src/+/0abb3a90f2..b07526b70d

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/fffc0b385f..fc6b52cdab
* buildtools/linux64: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25
* buildtools/mac: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25
* buildtools/win: git_revision:d823fd85da3fb83146f734377da454473b93a2b2..git_revision:155c53952ec2dc324b0438ce5b9bd4a286577d25
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/87207dd445..d47dd4e908
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/b3ae305fd5..a64dd87cec
* third_party/android_build_tools/manifest_merger: UiE3IQmTjQyDp6olH-K75Gup3wY_WezHKM9riMylXVcC..q4q38FXedJ-uNPtYpwR--VhUglwaiG95Nz1aNXyOL9gC
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/12e53bce03..e939ac77bb
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/22de5fb717..6aaae85821
* third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/80307e66e7..e3b94d0e5b
* third_party/r8: 4lmbDFBqkP3D6DWu4MC8eiktQ4wuHyTMVJIWoU_q30AC..vLrV1g3mole2jBVpiMB13SquCOCucEVK_ImpPqXYIR8C
* third_party/siso: git_revision:437716714a744e272fabdf1377b8878ccac26b43..git_revision:44d2b8f5b840adf521bb4912ccac31848f6d1448
* tools/android: https://chromium.googlesource.com/chromium/src/tools/android/+log/84f141bb4e..10697c9ce8
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/279d79a374..78c03ab18c
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/bcadedd547..b31325ceb7
* tools/skia_goldctl/linux: ZpyLtfuztdYI-RCkvm6kXlmx8ec1wYyrwXNI-lQEJKwC..SQswrvGi674ASEtZKS6NGrcxzcOAx9fdEvxSUwNCVkIC
* tools/skia_goldctl/mac_amd64: FpwpXsMPl8Mets8uet3zfFw8nNBpl69xJoTYESLUjl8C..vuB-Klm2s3uWsshi6g4r4l4fZox0RrWCgtSRKTxev3QC
* tools/skia_goldctl/mac_arm64: GuJOsvx5V5z8DvAM_HOVy6eBydQ0sO7dVso_p_L7KTgC..sqWmO8LOK7GgLCYuZo_PWkn6BcuBSgv16TPYoV44QUsC
* tools/skia_goldctl/win: LT6gNudC207ke0t4qv9IW_s27hoPIafnwpcfrzR8FzMC..4Y2pcWzsEQOJJ76XA1eaNSwef4YuyOrnQ-lSK1-71PkC
DEPS diff: https://chromium.googlesource.com/chromium/src/+/0abb3a90f2..b07526b70d/DEPS

Clang version changed llvmorg-19-init-2941-ga0b3dbaf:llvmorg-19-init-8091-gab037c4f
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/279d79a37479b4b12bb4c4c27d224fd8503fbee7..78c03ab18cb89612654b8faf957eb30635316466/scripts/update.py

Bug: skia:330350366, angleproject:8555, angleproject:8474
Change-Id: I70d907d78339dac9a0c0e7c6b96819c5cd62aa9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5465699
Reviewed-by: Geoff Lang <geof...@chromium.org>
Commit-Queue: Yuly Novikov <ynov...@chromium.org>

[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/third_party/dawn
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/tools/perf
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/third_party/depot_tools
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/testing
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/third_party/abseil-cpp
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/infra/specs/mixins.pyl
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/infra/specs/angle.json
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/tools/android
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/build
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/third_party/catapult
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/tools/clang
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/third_party/libc++/src
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/scripts/roll_chromium_deps.py
[modify] https://crrev.com/5f532b75c296286ebf4eb404096cd5f9e533a890/DEPS

[Git Watcher via monorail]

Comment #16 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c16

The following revision refers to this bug:

https://dawn.googlesource.com/dawn/+/0794566e597a14da217bf040dac2c5297aa87abc

commit 0794566e597a14da217bf040dac2c5297aa87abc
Author: Geoff Lang <geof...@google.com>
Date: Thu Apr 18 16:44:23 2024

Reland "Use abseil's build targets instead of custom ones."

This reverts commit 29b75b83730ce94abbb603f7dd4c0afbadf21192.

Reason for revert: Skia bots can now build ToT abseil:
https://g-issues.skia.org/issues/330350366?

Original change's description:

> Revert "Use abseil's build targets instead of custom ones."
>
> This reverts commit 2ce42fc95ab7cf7bbf97a9c48876c67c95f9cb78.
>
> Reason for revert: Can't roll into Skia due to old toolchains on Mac
>
> Original change's description:
> > Use abseil's build targets instead of custom ones.
> >
> > Chromium's abseil has been updated to no longer depend on external
> > build files like googletest. The required warning suppressions for dawn
> > have also been added.
> >
> > Bug: angleproject:8555
> > Change-Id: I9e590dd26301a5e8f5d670180bebc751a22ea052
> > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/178940
> > Kokoro: Kokoro <noreply+kok...@google.com>
> > Reviewed-by: Austin Eng <en...@chromium.org>
> > Commit-Queue: Geoff Lang <geof...@google.com>
> > Reviewed-by: Corentin Wallez <cwa...@chromium.org>
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: angleproject:8555
> Change-Id: I64b4809f7d3b7f3ad1802aac11461be3960be55c
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/179144
> Kokoro: Kokoro <noreply+kok...@google.com>
> Commit-Queue: Geoff Lang <geof...@google.com>
> Reviewed-by: Corentin Wallez <cwa...@chromium.org>
> Reviewed-by: Florin Malita <fma...@chromium.org>

Bug: angleproject:8555
Change-Id: Ic498c3630e68ea9871264180133549751f32f17f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/184620

Reviewed-by: Austin Eng <en...@chromium.org>
Commit-Queue: Geoff Lang <geof...@google.com>

[modify] https://dawn.googlesource.com/dawn/+/0794566e597a14da217bf040dac2c5297aa87abc/third_party/abseil-cpp
[modify] https://dawn.googlesource.com/dawn/+/0794566e597a14da217bf040dac2c5297aa87abc/src/dawn/wire/BUILD.gn
[modify] https://dawn.googlesource.com/dawn/+/0794566e597a14da217bf040dac2c5297aa87abc/DEPS
[modify] https://dawn.googlesource.com/dawn/+/0794566e597a14da217bf040dac2c5297aa87abc/src/dawn/native/BUILD.gn
[modify] https://dawn.googlesource.com/dawn/+/0794566e597a14da217bf040dac2c5297aa87abc/src/tint/BUILD.gn
[delete] https://dawn.googlesource.com/dawn/+/8466a8c8d7a974b7f78c4b3b554ab81b35f7e96f/third_party/gn/abseil-cpp/BUILD.gn

[Git Watcher via monorail]

Comment #17 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c17

The following revision refers to this bug:

https://dawn.googlesource.com/dawn/+/ed672dd1451a1b6e006b7a5156048c79b49677e6

commit ed672dd1451a1b6e006b7a5156048c79b49677e6
Author: Geoff Lang <geof...@google.com>
Date: Mon Apr 29 14:26:28 2024

Revert "Reland "Use abseil's build targets instead of custom ones.""

This reverts commit 0794566e597a14da217bf040dac2c5297aa87abc.

Reason for revert: Chromium's abseil not buildable in the skia tree.
Need to use custom build files still.

Original change's description:

Change-Id: I70791061331b1386d26aaa90a03b8170a7f4ab40
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/186002

Reviewed-by: Austin Eng <en...@chromium.org>
Commit-Queue: Geoff Lang <geof...@google.com>

[modify] https://dawn.googlesource.com/dawn/+/ed672dd1451a1b6e006b7a5156048c79b49677e6/third_party/abseil-cpp
[modify] https://dawn.googlesource.com/dawn/+/ed672dd1451a1b6e006b7a5156048c79b49677e6/src/dawn/wire/BUILD.gn
[modify] https://dawn.googlesource.com/dawn/+/ed672dd1451a1b6e006b7a5156048c79b49677e6/DEPS
[modify] https://dawn.googlesource.com/dawn/+/ed672dd1451a1b6e006b7a5156048c79b49677e6/src/dawn/native/BUILD.gn
[modify] https://dawn.googlesource.com/dawn/+/ed672dd1451a1b6e006b7a5156048c79b49677e6/src/tint/BUILD.gn
[add] https://dawn.googlesource.com/dawn/+/ed672dd1451a1b6e006b7a5156048c79b49677e6/third_party/gn/abseil-cpp/BUILD.gn

[Git Watcher via monorail]

Comment #18 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c18

The following revision refers to this bug:

https://chromium.googlesource.com/angle/angle/+/c96435eda841bfcf34657919f39b97ed9ad7e670

commit c96435eda841bfcf34657919f39b97ed9ad7e670
Author: Geoff Lang <geof...@chromium.org>
Date: Fri May 10 20:06:19 2024

Use Chromium's abseil build files with Dawn.

Roll Dawn and set build_with_angle so that it uses chromium's abseil
buildfiles when building in an ANGLE checkout.

Bug: angleproject:8555
Change-Id: I8fc40fdefad734ef62bce374aa948367a42c03c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5531113
Auto-Submit: Geoff Lang <geof...@chromium.org>
Reviewed-by: Yuly Novikov <ynov...@chromium.org>
Commit-Queue: Yuly Novikov <ynov...@chromium.org>

[modify] https://crrev.com/c96435eda841bfcf34657919f39b97ed9ad7e670/third_party/dawn
[modify] https://crrev.com/c96435eda841bfcf34657919f39b97ed9ad7e670/BUILD.gn
[modify] https://crrev.com/c96435eda841bfcf34657919f39b97ed9ad7e670/DEPS
[modify] https://crrev.com/c96435eda841bfcf34657919f39b97ed9ad7e670/build_overrides/dawn.gni

[Git Watcher via monorail]

Comment #19 on issue 8555 by Git Watcher: Since updating ANGLE, I now have symbol duplication at link from multiple copies of abseil
https://bugs.chromium.org/p/angleproject/issues/detail?id=8555#c19

The following revision refers to this bug:

https://chromium.googlesource.com/angle/angle/+/53cb3f480c71907301cda9db7531ba49d8ef066e

commit 53cb3f480c71907301cda9db7531ba49d8ef066e
Author: Yuly Novikov <ynov...@chromium.org>
Date: Sat May 11 16:18:22 2024

Fix non-WebGPU component build

Need to build abseil as a component, like it was before
https://chromium-review.googlesource.com/c/angle/angle/+/5371323
otherwise same symbols are defined in multiple ANGLE libs.

Bug: angleproject:8555
Change-Id: Ie7eacb682064e61bf3d5b24953c60e30d33814b3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5527302
Reviewed-by: Geoff Lang <geof...@chromium.org>
Auto-Submit: Yuly Novikov <ynov...@chromium.org>
Commit-Queue: Geoff Lang <geof...@chromium.org>

[modify] https://crrev.com/53cb3f480c71907301cda9db7531ba49d8ef066e/BUILD.gn