Issue 8695 in angleproject: Fold nested std::max calls

[lexa.… via monorail]

Status: Available
Owner: ----
Priority: Medium
Type: Enhancement

New issue 8695 by lexa....@gmail.com: Fold nested std::max calls
https://bugs.chromium.org/p/angleproject/issues/detail?id=8695

When a maximum of three values is needed, an initializer list with all three values could be used instead of nesting two std::max calls.

--
You received this message because:
1. The project was configured to send all issue notifications to this address

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

[Git Watcher via monorail]

Updates:
Status: Fixed

Comment #1 on issue 8695 by Git Watcher: Fold nested std::max calls
https://bugs.chromium.org/p/angleproject/issues/detail?id=8695#c1

The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/0ac0603e5f76422279086e0abe22db5d1b866681

commit 0ac0603e5f76422279086e0abe22db5d1b866681
Author: Alexey Knyazev <lexa.k...@gmail.com>
Date: Tue May 14 00:00:00 2024

Fold nested std::max calls

When a maximum of three values is needed,
an initializer list with all three values

is more readable than two std::max calls.

Fixed: angleproject:8695
Change-Id: I073ea1af07b215610c85981eea03f6e73107bce6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5541974
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.k...@gmail.com>

[modify] https://crrev.com/0ac0603e5f76422279086e0abe22db5d1b866681/src/image_util/loadimage_etc.cpp
[modify] https://crrev.com/0ac0603e5f76422279086e0abe22db5d1b866681/src/libANGLE/Texture.cpp
[modify] https://crrev.com/0ac0603e5f76422279086e0abe22db5d1b866681/src/libANGLE/renderer/d3d/TextureD3D.cpp
[modify] https://crrev.com/0ac0603e5f76422279086e0abe22db5d1b866681/src/common/mathutil.cpp
[modify] https://crrev.com/0ac0603e5f76422279086e0abe22db5d1b866681/src/libANGLE/renderer/metal/mtl_resources.mm
[modify] https://crrev.com/0ac0603e5f76422279086e0abe22db5d1b866681/src/tests/gl_tests/ShaderAlgorithmTest.cpp