Issue 7882 in angleproject: Implement GL_ARM_shader_framebuffer_fetch for Vulkan
18 views
Skip to first unread message
sris… via monorail
Dec 9, 2022, 3:40:52 PM12/9/22
to angleproj...@googlegroups.com
Status: Started
Owner: sri...@google.com
OS: Android
Priority: Medium
Renderer: Vulkan
Type: Task
New issue 7882 by sri...@google.com: Implement GL_ARM_shader_framebuffer_fetch for Vulkan
https://bugs.chromium.org/p/angleproject/issues/detail?id=7882
Required by Battle Prime, an app on Android, and used by Lineage 2: Revolution (with fallbacks if it is absent).
--
You received this message because:
1. The project was configured to send all issue notifications to this address
You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
Owner: sri...@google.com
OS: Android
Priority: Medium
Renderer: Vulkan
Type: Task
New issue 7882 by sri...@google.com: Implement GL_ARM_shader_framebuffer_fetch for Vulkan
https://bugs.chromium.org/p/angleproject/issues/detail?id=7882
Required by Battle Prime, an app on Android, and used by Lineage 2: Revolution (with fallbacks if it is absent).
--
You received this message because:
1. The project was configured to send all issue notifications to this address
You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings
Git Watcher via monorail
Jan 26, 2023, 1:51:09 PM1/26/23
to angleproj...@googlegroups.com
Comment #1 on issue 7882 by Git Watcher: Implement GL_ARM_shader_framebuffer_fetch for Vulkan
https://bugs.chromium.org/p/angleproject/issues/detail?id=7882#c1
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/0133b6f186fae5b188eafe7ad35c4a664e599853
commit 0133b6f186fae5b188eafe7ad35c4a664e599853
Author: Sean Risser <sri...@google.com>
Date: Fri Jan 20 20:02:27 2023
Add GL_ARM_shader_framebuffer_fetch builtins
Bug: b/242419750
Bug: angleproject:7882
Change-Id: I85582ad21e58e448b740789ec88f783c8b95ee01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4189028
Reviewed-by: Cody Northrop <cnor...@google.com>
Commit-Queue: Sean Risser <sri...@google.com>
Reviewed-by: Shahbaz Youssefi <syou...@chromium.org>
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libANGLE/capture/capture_gles_ext_autogen.h
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libGLESv2/libGLESv2_no_capture_autogen.def
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libANGLE/Context_gles_ext_autogen.h
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/extension_data/pixel_6_android_13.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/code_generation_hashes/interpreter_utils.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/doc/ExtensionSupport.md
[add] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/tests/restricted_traces/check_trace_diffs.py
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libGLESv2/entry_points_gles_ext_autogen.cpp
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/code_generation_hashes/GL_EGL_WGL_loader.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libANGLE/gles_extensions_autogen.cpp
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/common/gl_enum_utils_autogen.cpp
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libANGLE/validationESEXT_autogen.h
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libGLESv2/libGLESv2_autogen.def
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libGLESv2/entry_points_gles_ext_autogen.h
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libGLESv2/opengl32_autogen.def
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/compiler/translator/SymbolTable_ESSL_autogen.cpp
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libGLESv2/opengl32_with_wgl_autogen.def
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/code_generation_hashes/Static_builtins.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/code_generation_hashes/GL_EGL_entry_points.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/extension_data/swiftshader_linux.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/registry_xml.py
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/extension_data/swiftshader_win10.json
[add] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/tests/restricted_traces/tests.csv
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libGLESv2/libGLESv2_with_capture_autogen.def
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libGLESv2/libGLESv2_vulkan_secondaries_autogen.def
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/code_generation_hashes/proc_table.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/compiler/translator/SymbolTable_autogen.cpp
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/code_generation_hashes/Extension_files.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/extension_data/swiftshader_win10_gles1.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libANGLE/gles_extensions_autogen.h
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/compiler/translator/builtin_variables.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/scripts/code_generation_hashes/GLenum_value_to_string_map.json
[modify] https://crrev.com/0133b6f186fae5b188eafe7ad35c4a664e599853/src/libGLESv2/libGLESv2_autogen.cpp
Git Watcher via monorail
Jan 27, 2023, 4:46:08 PM1/27/23
to angleproj...@googlegroups.com
Comment #2 on issue 7882 by Git Watcher: Implement GL_ARM_shader_framebuffer_fetch for Vulkan
https://bugs.chromium.org/p/angleproject/issues/detail?id=7882#c2
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/b96d1955957c3f924faa5d559f16fb10173d2932
commit b96d1955957c3f924faa5d559f16fb10173d2932
Author: Sean Risser <sri...@google.com>
Date: Fri Jan 20 20:06:34 2023
Implement GL_ARM_shader_framebuffer_fetch
GL_ARM_shader_framebuffer_fetch allows fragment shaders to read
gl_LastFragColorARM. The extension is similar to
GL_EXT_shader_framebuffer_fetch, but is more limited in its
capabilities.
GL_ARM_shader_framebuffer_fetch was removed from HasFramebufferFetch()
because it acts differently from GL_EXT_shader_framebuffer_fetch in
significant enough ways that it should not be included in that
single-use function.
Tests: FramebufferFetchES31.*_ARM
commit b96d1955957c3f924faa5d559f16fb10173d2932
Author: Sean Risser <sri...@google.com>
Date: Fri Jan 20 20:06:34 2023
Implement GL_ARM_shader_framebuffer_fetch
GL_ARM_shader_framebuffer_fetch allows fragment shaders to read
gl_LastFragColorARM. The extension is similar to
GL_EXT_shader_framebuffer_fetch, but is more limited in its
capabilities.
GL_ARM_shader_framebuffer_fetch was removed from HasFramebufferFetch()
because it acts differently from GL_EXT_shader_framebuffer_fetch in
significant enough ways that it should not be included in that
single-use function.
Tests: FramebufferFetchES31.*_ARM
Change-Id: Id3a25c8ee50ca3e2a4c30a2261f507b0b53511ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083108
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4083108
Reviewed-by: Cody Northrop <cnor...@google.com>
Reviewed-by: Geoff Lang <geof...@chromium.org>
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/libANGLE/Compiler.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/OutputSPIRV.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/tree_ops/vulkan/ReplaceForShaderFramebufferFetch.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/libANGLE/renderer/gl/renderergl_utils.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/util.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/ValidateAST.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/tree_ops/vulkan/ReplaceForShaderFramebufferFetch.h
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/libANGLE/queryutils.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/ParseContext.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/tests/gl_tests/FramebufferFetchTest.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/SymbolTable.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/TranslatorVulkan.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/CollectVariables.cpp
Reviewed-by: Geoff Lang <geof...@chromium.org>
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/libANGLE/Compiler.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/OutputSPIRV.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/tree_ops/vulkan/ReplaceForShaderFramebufferFetch.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/libANGLE/renderer/gl/renderergl_utils.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/util.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/ValidateAST.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/tree_ops/vulkan/ReplaceForShaderFramebufferFetch.h
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/libANGLE/queryutils.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/ParseContext.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/tests/gl_tests/FramebufferFetchTest.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/SymbolTable.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/TranslatorVulkan.cpp
[modify] https://crrev.com/b96d1955957c3f924faa5d559f16fb10173d2932/src/compiler/translator/CollectVariables.cpp
Git Watcher via monorail
Aug 31, 2023, 12:02:19 PM8/31/23
to angleproj...@googlegroups.com
Comment #3 on issue 7882 by Git Watcher: Implement GL_ARM_shader_framebuffer_fetch for Vulkan
https://bugs.chromium.org/p/angleproject/issues/detail?id=7882#c3
The following revision refers to this bug:
https://chromium.googlesource.com/angle/angle/+/ed7e05bed633a3bdd29fba36688e26948c2880ca
commit ed7e05bed633a3bdd29fba36688e26948c2880ca
Author: Roman Lavrov <rom...@google.com>
Date: Thu Aug 31 14:44:05 2023
Cleanup: remove tests.csv
Looks like it was added accidentally in https://crrev.com/c/4189028
commit ed7e05bed633a3bdd29fba36688e26948c2880ca
Author: Roman Lavrov <rom...@google.com>
Date: Thu Aug 31 14:44:05 2023
Cleanup: remove tests.csv
Looks like it was added accidentally in https://crrev.com/c/4189028
Change-Id: I1d92b4a7001a1418bfea77e2b0945ee7a070dad5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4832095
Auto-Submit: Roman Lavrov <rom...@google.com>
Commit-Queue: Roman Lavrov <rom...@google.com>
Commit-Queue: Cody Northrop <cnor...@google.com>
Reviewed-by: Cody Northrop <cnor...@google.com>
[delete] https://crrev.com/0b20cd6a86d11d1db891c5d62748d324cf6fac96/src/tests/restricted_traces/tests.csv
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4832095
Auto-Submit: Roman Lavrov <rom...@google.com>
Commit-Queue: Roman Lavrov <rom...@google.com>
Commit-Queue: Cody Northrop <cnor...@google.com>
Reviewed-by: Cody Northrop <cnor...@google.com>
[delete] https://crrev.com/0b20cd6a86d11d1db891c5d62748d324cf6fac96/src/tests/restricted_traces/tests.csv
Reply all
Reply to author
Forward
0 new messages