[PATCH] Treat Qemu and VirtualBox tablet-style inputs as absolute coordinate mouse pointer

246 views
Skip to first unread message

Jon Doe

unread,
Dec 19, 2018, 6:25:58 AM12/19/18
to Android-x86
Hi,

I find it difficult to work with the current "invisible finger" or "drag pointer" interface provided to the virtual absolute coordinate pointing devices. Instead, this patch classifies them as a regular mouse pointer (INPUT_DEVICE_CLASS_CURSOR), which is more intuitive to work with.

The patch looks for absolute coordinate x-y axis (ABS_X, ABS_Y) devices with a relative coordinate vertical mouse scroll wheel (REL_WHEEL), as provided by both "QEMU USB Tablet" and "VirtualBox USB Tablet" devices. Regular touch screens do not satisfy this condition, so they are left alone to be classified as INPUT_DEVICE_CLASS_TOUCH.

As a convenience, idc files are also attached to enable orientation aware movement in any rotation.
QEMU_QEMU_USB_Tablet.idc
QEMU_Virtio_Tablet.idc
VirtualBox_USB_Tablet.idc
abs_virt_mouse.patch

Chih-Wei Huang

unread,
Dec 20, 2018, 2:58:32 AM12/20/18
to Android-x86
Jon Doe <tuk...@gmail.com> 於 2018年12月19日 週三 下午7:26寫道:
>
> I find it difficult to work with the current "invisible finger" or "drag pointer" interface provided to the virtual absolute coordinate pointing devices. Instead, this patch classifies them as a regular mouse pointer (INPUT_DEVICE_CLASS_CURSOR), which is more intuitive to work with.
>
> The patch looks for absolute coordinate x-y axis (ABS_X, ABS_Y) devices with a relative coordinate vertical mouse scroll wheel (REL_WHEEL), as provided by both "QEMU USB Tablet" and "VirtualBox USB Tablet" devices. Regular touch screens do not satisfy this condition, so they are left alone to be classified as INPUT_DEVICE_CLASS_TOUCH.

Looks promising.

However, the patch can't be applied clean to oreo-x86 branch.
Please provide a git-format patch to the latest oreo-x86 branch.
Thanks a lot!

> As a convenience, idc files are also attached to enable orientation aware movement in any rotation.


--
Chih-Wei
Android-x86 project
http://www.android-x86.org

Jon Doe

unread,
Dec 23, 2018, 9:50:37 AM12/23/18
to Android-x86
Patch against latest oreo branch is attached.
abs_mouse_pointer-oreo.patch

Chih-Wei Huang

unread,
Dec 26, 2018, 3:30:47 AM12/26/18
to Android-x86
I've applied them.
Thank you very much!

Jon Doe <tuk...@gmail.com> 於 2018年12月23日 週日 下午10:50寫道:
</tuk...@gmail.com>

Chih-Wei Huang

unread,
Jan 15, 2019, 11:37:37 AM1/15/19
to Android-x86
Chih-Wei Huang <cwh...@android-x86.org> 於 2018年12月26日 週三 下午4:30寫道:
> >> Jon Doe <tuk...@gmail.com> 於 2018年12月19日 週三 下午7:26寫道:
> >> >
> >> > I find it difficult to work with the current "invisible finger" or "drag pointer" interface provided to the virtual absolute coordinate pointing devices. Instead, this patch classifies them as a regular mouse pointer (INPUT_DEVICE_CLASS_CURSOR), which is more intuitive to work with.
> >> >
> >> > The patch looks for absolute coordinate x-y axis (ABS_X, ABS_Y) devices with a relative coordinate vertical mouse scroll wheel (REL_WHEEL), as provided by both "QEMU USB Tablet" and "VirtualBox USB Tablet" devices. Regular touch screens do not satisfy this condition, so they are left alone to be classified as INPUT_DEVICE_CLASS_TOUCH.

Besides QEMU and VirtualBox, I have also added the same tablet-style
inputs support to VMware and Hyper-V based on your patch.
This is included in the 8.1-r1 release.
Thank you again for providing such a great feature!
Reply all
Reply to author
Forward
0 new messages