> --
> You received this message because you are subscribed to the Google Groups "Android-x86" group.
> To post to this group, send email to andro...@googlegroups.com.
> To unsubscribe from this group, send email to android-x86...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/android-x86?hl=en.
>
>
--
Android-x86
http://www.android-x86.org
Yi
Just got some time to read your patches.
In 0001-Added-Android-x86-preference-for-power-off-dialog-an.patch,
you called it AndroidX86Settings,
I think that's not appropriate.
I hope to avoid more "android-x86 specific" changes.
Your patches is not really android-x86 specific.
So can you just name it like PowerSettings or so?
2010/12/12 kwok <kwok...@live.nl>:
> Could any one (who has commit privilege) apply this patch to the
> froyo branch?
>
> I think that some other people would like this feature as well.
>
--
Chih-Wei
Android-x86 project
http://www.android-x86.org
Sounds better. But where is it?
That usually keeps users from fiddling too much :).
Al.
Thank you for the updates.
* Please merge the two changes in Settings app.
You can use git commit --amend to modify previous commit.
* In res/values/strings.xml of Settings app, you moved
'Disable showing screen lock' to <!-- Advanced settings -->.
Any reason to do that? It didn't belongs to the advanced settings.
Please do not touch unrelated part to avoid review overheads.
If you hope to change it, it should belong to another commit.
Maybe rename 'Disable power off confirmation'
to 'Disable power off/reboot confirmation'.
2010/12/16 Chih-Wei Huang <cwh...@android-x86.org>:
> 2010/12/15 kwok <kwok...@live.nl>:
>>
>> Here is the new patch: http://dl.dropbox.com/u/10672391/Android/AdvancedSetting.zip
>> "Android-x86 Settings" is renamed to "Advanced Settings"
Ok, applied (with some modifications)
Thank you for the contributions.
2010/12/21 kwok <kwok...@live.nl>:
> And here is the reboot part of the patch: http://dl.dropbox.com/u/10672391/Android/reboot.zip
>
--
Applied. Thanks.2010/12/21 kwok <kwok...@live.nl>:
> And here is the reboot part of the patch: http://dl.dropbox.com/u/10672391/Android/reboot.zip
>