Using copy-firmware.sh to copy firmware instead of using PRODUCT_COPY_FILES

[Huy Minh Bùi (HMTheBoy154)]

Traditionally Android-x86 use `PRODUCT_COPY_FILES` to copy firmware to /system/lib/firmware. This still being used today, however it have a few issues, especially if you use this method with newer linux-firmware repo: 

- It doesn't symlinks all the firmware, especially with brcm and nvidia

- It will create errors, especially with newer AOSP builds like s-x86 or t-x86 due to the fact that some brcm firmware have spaces.

Thankfully, on linux-firmware repo there is a script called copy-firmware.sh. What this script does is that it will read a file inside called WHENCE to check which file need to copy or which file need to symlink and then do all of that in a specified output. I tried this script and it works perfectly with BlissOS 15.8.2 (s-x86) so far. If anyone interested in using it here's what I did :

- For r-x86 and above, whitelist "install" command

https://review.blissroms.org/c/platform_build_soong/+/15481

- Remove firmware.mk and Android.mk out from device/generic/firmware 

https://github.com/hmtheboy154/device_generic_firmware/commit/e7428c84222825a770361efbf0d3546c829fef52

- Define the firmware location on the copy-firmware.sh script
https://github.com/hmtheboy154/device_generic_firmware/commit/422cfe706a2a50e8ff6377cf035e3602ed048935

- Include it in kernel.mk and remove firmware.mk out from device.mk

https://github.com/supremegamers/device_generic_common/commit/5b1479e719def50243fdc6d355fe5269379581e3

[Huy Minh Bùi (HMTheBoy154)]

here is my $(TARGET_OUT)/lib/firmware/brcm after using the script :
https://i.ibb.co/7z7nf6S/image.png

This is also handy to cut out the firmware we don't need. Instead of cherry-picking commits to update the firmware we can just edit WHENCE instead

Vào lúc 03:02:32 UTC+7 ngày Thứ Sáu, 23 tháng 12, 2022, Huy Minh Bùi đã viết: