it looks reasonable but there are parts like BIP and UICC access that
are not secure store related.
Would then help to have them separated to expedite the review and
acceptance then?
This part is really important and could be seen independent.
What would you suggest?
Petr
Thank you for the contribution! Splitting it up this way makes it
easier to review and get into the platform.
We're starting to review the code, but there are a few administrative
requests that cover all the patches. First, for code outside external/
we require the copyright to be assigned to "The Android Open Source
Project". For contributions coming from outside Google the convention
is to add a comment immediately following the copyright & license
comment in the form:
/* Contributed by: <company> */
to recognize the source of the contribution in the code. See
https://review.source.android.com/#change,18363 for an example of this
being applied in a previous code review.
Second, it looks like a good amount of the new code does not follow
the Android code style guidelines described at
http://s.android.com/source/code-style.html. The code doesn't have to
be 100% compliant, of course, but we'd like to see the major things
like variable naming conventions, parentheses placement, and 4 space
indention with no hard tabs fixed. Most people working on Android have
their editors setup to format this way and it can make a mess of
patches when editors change those things on you automatically.
Last, we'd like to see the public facing APIs in this contribution put
into a shared library instead of added directly to the framework. The
existing secure element APIs are done this way (see
http://android.git.kernel.org/?p=platform/frameworks/base.git;a=tree;f=nfc-extras;h=05023071dd91252d33a0d1ccea04a5dd0abf1926;hb=refs/heads/master)
as well. If you'd like more info on how to set this up please let me
know and I can help.
-Jeff