Re: Who to ask to review patches.

[Brian Carlstrom]

I'd use git blame or git log on the file to find likely reviewers, or
perhaps looking at recent changes in that project to see who has
reviewed there in the past. in your case,
https://android-review.googlesource.com/#/q/project:platform/frameworks/base,n,z

-bri

On Tue, Nov 6, 2012 at 3:56 AM, Tim Hutt <tdh...@gmail.com> wrote:
> Hi, I got fed up with the Android documentation being rather shoddy in
> places, and after submitting a few ignored bug reports about them, I decided
> I may as well just fix the documentation myself and upload the changes it to
> gerrit. I've done the first very small change here:
>
> https://android-review.googlesource.com/45873
>
> But nobody has reviewed it, and I'm not sure who to ask. I also don't know
> who is responsible for that code, and I vaguely remember reading that they
> would be automatically notified anyway.
>
> What's the procedure here?
>
> --
>
>
>

[Jean-Baptiste Queru]

It appropriate as long as you use it with moderation.

At one extreme, if you git blame your way into finding one or two
people who've touched that code most recently, double-check that the
changes are "true" changes as opposed to source code management, and
confirm that they're actively reviewing changes on the AOSP Gerrit,
that's fine.

At another extreme, if you add a dozen people who've been active in
that same git project and ping them several times a week through
Gerrit or direct email, you probably won't make many friends.

JBQ

On Tue, Nov 6, 2012 at 10:53 AM, Tim Hutt <tdh...@gmail.com> wrote:
> Ah git blame works great, thanks! Still feels a bit rude just to randomly
> add people, but maybe I am just being too polite!

> --
>
>
>



--
Jean-Baptiste M. "JBQ" Queru
Technical Lead, Android Open Source Project, Google.

Questions sent directly to me that have no reason for being private
will likely get ignored or forwarded to a public forum with no further
warning.