issue of lunch menu about Android 15.0.0_r2

[Jericho Wang]

Anyone know why the lunch menu all fail ?  I need the oriole_aosp_debug.

=================================================

You're building on Linux

Warning: Cannot display lunch menu.

Note: You can invoke lunch with an explicit target:

  usage: lunch [target]

Which would you like? [aosp_cf_x86_64_phone-trunk_staging-eng]
Pick from common choices above (e.g. 13) or specify your own (e.g. aosp_barbet-trunk_staging-eng): 13

Invalid lunch combo:
Valid combos must be of the form <product>-<release>-<variant>

[Faqiang Zhu]

I checked this issue before: the sdk version and release configs are used before the menu can be displayed, but they are not set before yet at that stage. which causes the build error.

Google actually add a new command `lunch2`, but it does not support to print the menu.

a workaround to make the lunch command can print menu is as below. I should emphasize it's a workaround, I'm not sure whether it is proper to do so.

diff --git a/core/release_config.mk b/core/release_config.mk
index 2898868682..311a68805f 100644
--- a/core/release_config.mk
+++ b/core/release_config.mk
@@ -277,7 +277,7 @@ endif

 # During pass 1 of product config, using a non-existent release config is not an error.
 # We can safely assume that we are doing pass 1 if DUMP_MANY_VARS=="PRODUCT_RELEASE_CONFIG_MAPS".
-ifneq (,$(_final_product_config_pass))
+ifneq (,$(filter TARGET_PRODUCT, $(DUMP_MANY_VARS)))
     ifeq ($(filter $(ALL_RELEASE_CONFIGS_FOR_PRODUCT), $(TARGET_RELEASE)),)
         $(error No release config found for TARGET_RELEASE: $(TARGET_RELEASE). Available releases are: $(ALL_RELEASE_CONFIGS_FOR_PRODUCT))
     endif
diff --git a/envsetup.sh b/envsetup.sh
index 06dadd3f38..e569a83c56 100644
--- a/envsetup.sh
+++ b/envsetup.sh
@@ -408,7 +408,7 @@ function print_lunch_menu()
 {
     local uname=$(uname)
     local choices
-    choices=$(TARGET_BUILD_APPS= TARGET_PRODUCT= TARGET_RELEASE= TARGET_BUILD_VARIANT= _get_build_var_cached COMMON_LUNCH_CHOICES 2>/dev/null)
+    choices=$(TARGET_BUILD_APPS= TARGET_PRODUCT= TARGET_RELEASE= TARGET_BUILD_VARIANT= RELEASE_PLATFORM_SDK_VERSION=0 _get_build_var_cached COMMON_LUNCH_CHOICES 2>/dev/null)
     local ret=$?

     echo
@@ -467,7 +467,7 @@ function lunch()
         selection=aosp_cf_x86_64_phone-trunk_staging-eng
     elif (echo -n $answer | grep -q -e "^[0-9][0-9]*$")
     then
-        local choices=($(TARGET_BUILD_APPS= TARGET_PRODUCT= TARGET_RELEASE= TARGET_BUILD_VARIANT= _get_build_var_cached COMMON_LUNCH_CHOICES 2>/dev/null))
+        local choices=($(TARGET_BUILD_APPS= TARGET_PRODUCT= TARGET_RELEASE= TARGET_BUILD_VARIANT= RELEASE_PLATFORM_SDK_VERSION=0 _get_build_var_cached COMMON_LUNCH_CHOICES 2>/dev/null))
         if [ $answer -le ${#choices[@]} ]
         then
             # array in zsh starts from 1 instead of 0.

[Dan Willemsen]

It's very uncommon within Google to use the interactive version of `lunch` -- if you know what you want to build, just specify it on the command line. It's shorter and faster to do so.

--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to android-...@googlegroups.com
To unsubscribe from this group, send email to
android-buildi...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to android-buildi...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/android-building/2f889fa5-f873-4fa4-ad4d-b5e4f52b1871n%40googlegroups.com.

[Jericho Wang]

Hi Dan

building on oriole (pixel6) for example, "lunch aosp_oriole-userdebug" is sufficient before Android 14, but can't get to work in Android 15, 

do you have a menu online we can check ?

=====================================================================================

jericho@jericho:~/work/android-15.0.0_r2$ source build/envsetup.sh
jericho@jericho:~/work/android-15.0.0_r2$ lunch aosp_oriole-userdebug

Invalid lunch combo: aosp_oriole-userdebug

Valid combos must be of the form <product>-<release>-<variant>

jericho@jericho:~/work/android-15.0.0_r2$ lunch aosp-oriole_userdebug

Invalid lunch combo: aosp-oriole_userdebug

Valid combos must be of the form <product>-<release>-<variant>

[Mattijs Korpershoek]

Hi Jericho,

$ /mnt/work/android-15/ ls build/release/release_configs
ap3a.textproto root.textproto trunk_staging.textproto

So on android-15.0_r2, the release is ap3a.

Try to run:

$ lunch aosp_oriole-ap3a-userdebug

On lun., nov. 18, 2024 at 18:20, Jericho Wang <misslebu...@gmail.com> wrote:

> Hi Dan
>
> building on oriole (pixel6) for example, "lunch aosp_oriole-userdebug" is
> sufficient before Android 14, but can't get to work in Android 15,
> do you have a menu online we can check ?
>
> =====================================================================================
>
> jericho@jericho:~/work/android-15.0.0_r2$ source build/envsetup.sh
> jericho@jericho:~/work/android-15.0.0_r2$ lunch aosp_oriole-userdebug
>
> Invalid lunch combo: aosp_oriole-userdebug
> Valid combos must be of the form <product>-<release>-<variant>
> jericho@jericho:~/work/android-15.0.0_r2$ lunch aosp-oriole_userdebug
>
> Invalid lunch combo: aosp-oriole_userdebug
> Valid combos must be of the form <product>-<release>-<variant>
>
> On Tuesday, November 19, 2024 at 10:14:10 AM UTC+8 Dan Willemsen wrote:
>
>> It's very uncommon within Google to use the interactive version of `lunch`
>> -- if you know what you want to build, just specify it on the command line.
>> It's shorter and faster to do so.
>>
>> On Mon, Nov 18, 2024 at 9:11 PM Faqiang Zhu <faqia...@nxp.com> wrote:
>>
>>> I checked this issue before: the sdk version and release configs are used
>>> before the menu can be displayed, but they are not set before yet at that
>>> stage. which causes the build error.
>>>
>>> Google actually add a new command `lunch2`, but it does not support to
>>> print the menu.
>>>

>>> a *workaround *to make the lunch command can print menu is as below. I
>>> should emphasize it's a *workaround*, I'm not sure whether it is proper

>>> to do so.
>>>
>>> diff --git a/core/release_config.mk b/core/release_config.mk

>>> index 2898868682 <(289)%20886-8682>..311a68805f 100644

>>> <https://groups.google.com/d/msgid/android-building/2f889fa5-f873-4fa4-ad4d-b5e4f52b1871n%40googlegroups.com?utm_medium=email&utm_source=footer>
>>> .

>>>
>>
>
> --
> --
> You received this message because you are subscribed to the "Android Building" mailing list.
> To post to this group, send email to android-...@googlegroups.com
> To unsubscribe from this group, send email to
> android-buildi...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/android-building?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups "Android Building" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to android-buildi...@googlegroups.com.

> To view this discussion visit https://groups.google.com/d/msgid/android-building/c3a47cd4-9fc5-4d7c-ab13-5fa1634f5f5cn%40googlegroups.com.