Is AVX2 now a mandatory ABI requirement for x86 platforms?

[Michael Goffioul]

Since this commit, webrtc audio processing module is compiled with AVX2 enabled. 

https://cs.android.com/android/_/android/platform/external/webrtc/+/b5b78192e10ba90978fb8228e7eb9fcf75c83f0c

This makes the module fail to load on platforms that do not support AVX2. E.g. generates SIGILL at a location like this one:

https://cs.android.com/android/platform/superproject/main/+/main:external/webrtc/modules/audio_processing/include/audio_processing.h;drc=4366c5469fefb6a1e641378a2bb152e3c5ad7421;l=186

Is this ABI requirement change documented anywhere? The main info about ABI I can find is this one, and it doesn't say AVX2 is mandatory (you can use it, but you need the proper safeguard, which webrtc module hasn't):

https://developer.android.com/ndk/guides/abis

Thanks,

Michael.

[enh]

+the webrtc OWNERS. (because, no, the Android ABI does not include
AVX2. i'm curious why this hasn't caused trouble for folks using the
emulator on older hardware, since the Studio requirements also don't
include AVX2?)

> --
> --
> You received this message because you are subscribed to the "Android Building" mailing list.
> To post to this group, send email to android-...@googlegroups.com
> To unsubscribe from this group, send email to
> android-buildi...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/android-building?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups "Android Building" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to android-buildi...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/android-building/CAB-99LuRHcyK%2BGrH8GSYwFWVCPhDNX7Xb7ZnoN62oFAzyagd3g%40mail.gmail.com.

[Michael Goffioul]

Hello? Anybody out there?

On Tue, Dec 19, 2023 at 9:29 AM Michael Goffioul <michael....@gmail.com> wrote:

Any update on this? I guess that now that the cat's out of the bag, it'll be difficult to put it back in, and AVX2 is a de facto ABI requirement.

To view this discussion on the web visit https://groups.google.com/d/msgid/android-building/CAJgzZoo%2BDn7SqLVpubhV_%3DPDtOdiu6aVa3W1Y_fT3p1Uhkwj0A%40mail.gmail.com.