product_config.mk syntax error ?

41 views
Skip to first unread message

Abhayadev S

unread,
Dec 21, 2021, 4:10:49 PM12/21/21
to Android Building
Hi,

I see the following in the build/make/core/product_config.mk

ifeq (,$(filter eng userdebug,$(TARGET_BUILD_VARIANT)),)

here ifeq has been given with 3 arguments right? is it expected? what will be the outcome?

regards,
abhay

Dan Willemsen

unread,
Dec 21, 2021, 4:56:04 PM12/21/21
to android-...@googlegroups.com
It appears that make & ckati both treat that as "" == "," (when $(TARGET_BUILD_VARIANT) is `user`), so that case never triggers.

I've posted a removal of the second comma here: https://android-review.googlesource.com/c/platform/build/+/1931200/

Thanks,
Dan



--
--
You received this message because you are subscribed to the "Android Building" mailing list.
To post to this group, send email to android-...@googlegroups.com
To unsubscribe from this group, send email to
android-buildi...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-building?hl=en

---
You received this message because you are subscribed to the Google Groups "Android Building" group.
To unsubscribe from this group and stop receiving emails from it, send an email to android-buildi...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/android-building/d1a1280f-8c6b-42c1-b384-1e12f1282c8an%40googlegroups.com.

Abhayadev S

unread,
Dec 28, 2021, 9:51:59 PM12/28/21
to Android Building
Great ! thanks for patching it.
Reply all
Reply to author
Forward
0 new messages