Suggested change in ListViewImageManager.getImageFromId

[roee88]

Currently for opening image resources Drawable.createFromStream is
used.
However createFromStream should only be used for raw resources and not
for density aware image drawables.

If possible could someone please apply the following patch (requires
API >= 4).
Thanks,
Roee.


Index: src/mobi/intuitit/android/widget/ListViewImageManager.java
===================================================================
--- src/mobi/intuitit/android/widget/ListViewImageManager.java
(revision 91)
+++ src/mobi/intuitit/android/widget/ListViewImageManager.java
(working copy)
@@ -107,10 +107,12 @@
if (LOGD)
Log.d(TAG, "image ID decoded");

- InputStream rawResource =
ctx.getResources().openRawResource(imgId);
+ Resources resources = ctx.getResources();
+ TypedValue value = new TypedValue ();
+ InputStream rawResource = resources.openRawResource(imgId, value);
try
{
- drawable = Drawable.createFromStream(rawResource,
ctx.getResources().getResourceName(imgId));
+ drawable = Drawable.createFromResourceStream(resources, value,
rawResource, resources.getResourceName(imgId));
}
finally
{

[AnderWeb Webbs]

It looks good to me but Boombuler must approve :)

[Florian Sundermann]

Looks good to me... Francois what do you think?

2011/7/4 AnderWeb Webbs <ande...@gmail.com>:

[Francois DESLANDES]

I'll make some test during next week-end ;)

2011/7/4 Florian Sundermann <boom...@googlemail.com>

--
Francois Deslandes @ Pure widgets - Android widgets