Testing branch, testers please

[Ander Web]

Hi, I've just commited to a new testing branch 2 changesets.
I'd like some testing from you guys before merging them into production...

The first patch (r50) tries to fix an old memory leak we got when removing scrollable widgets from the launcher app.
The second patch (r51) change the cursor queries so they don't block the UI thread by using AsyncQueryHandler (http://developer.android.com/intl/de/reference/android/content/AsyncQueryHandler.html).

I'm sure you all know I'm a bad coder so this changes may be evaluated and tested/optimized.

Regards,
ADW

[Florian Sundermann]

Hi @ all

since the latest ADW version included this patches and it works all
well for me, are there any other test results?

And another short question to the launcher devs:
Is there any list about which launcher implements which release of the
API code? I know that ADW and Zeam include the new 2.0 API but what
about the others?
I'm sitting on a finished version of my widget and can't release it
cause there are to many launchers that only implements 1.0 API.
(looking at you fede ;-))

Maybe a list of "supported launchers" would be great! cause the list
from the "startpage" of this group is not really up to date.

BTW: thx again to all of you for this ;)

Regards
Florian

[Florian Sundermann]

Hi @ all

just fixed a FC in the V2 API code if the cursor is null (empty) in
the testing branch and in the trunk.
So everyone including this code should update!

@ander I already pushed the fix ;)

Regards
Florian

[Francois DESLANDES]

Hi,

I have multiple users reports with image ressource ID usage problems
(exception) in scrollable API with latest ROM of HTC Desire HD and
myTouch 4G.

I am in holidays, so, I am not able to look at the problem, but does
anybody else get the issue ?

ciao,
Francois

2010/11/7 Florian Sundermann <boom...@googlemail.com>:

[rofl harrison]

I am getting reports of this problem as well.

Not sure how much I will be able to do without the device but will take a look!

[Florian Sundermann]

If anyone could send me a more detailed report I will have a look at it!

Regards
Florian

[Ander Web]

Yeah, "no log, no issue" ;)

[Francois DESLANDES]

Here is a logcat with LP implementation :
http://pastebin.com/F8yLuUe0

2010/11/8 Ander Web <ande...@gmail.com>:

[Florian Sundermann]

HTC Desire HD like the Agendawidget stacktrace I saw?

2010/11/8 Francois DESLANDES <kox...@gmail.com>:

[Francois DESLANDES]

no, HTC myTouch 4G, but exactly the same issue (very close phone it seems).

the logcat start :
Log Collector version: 1.1.0
Device model: HTC Glacier
Firmware version: 2.2.1
Kernel version: 2.6.32.21-g899d047
htc-kernel@and18-2 )
#1 PREEMPT Tue Oct 26 16:10:01 CST 2010
Build number: FRG83

I had same reports with HTC Desire HD.

2010/11/8 Florian Sundermann <boom...@googlemail.com>:

[Florian Sundermann]

Any of them with CM or AOSP sources or all with HTC build roms?

2010/11/8 Francois DESLANDES <kox...@gmail.com>:

[Francois DESLANDES]

stock ROMs

2010/11/8 Florian Sundermann <boom...@googlemail.com>:

[Florian Sundermann]

So I guess a HTC bug...
What else can be done except of catching the exception?

2010/11/8 Francois DESLANDES <kox...@gmail.com>:

[Francois DESLANDES]

may it would be interesting to break this line of code to see where
does the problem could come from :
drawable = Drawable.createFromResourceStream(ctx.getResources(), null,
ctx.getResources().openRawResource( imgId),
ctx.getResources().getResourceName(imgId));

HTC bug may be, but it would be good to find a trick to bypass it ...
it's never good when a user can use our API ...

Florian, if you can email me, I can give you the email of 1 or 2 users.
I'll be back in 1 week to more testing.

2010/11/8 Florian Sundermann <boom...@googlemail.com>:

[rofl harrison]

A friend of mine has a Desire HD on order, with any luck it will be here in a few days an I can try and find a workaround. Other then that the line number in BitmapFactory does not match the master of android on git. Potentially HTC has been meddling with this class?

[Florian Sundermann]

I could flash a sense-froyo rom to my desire and see if I can
reproduce the issue...
Maybe even a desire HD rom if it works...

Any reports of "normal" desire users?

[Ander Web]

Could this be caused by an underlying oom error when trying to load a resource so it generates the npe later?

[Francois DESLANDES]

No, no problem reported with normal Desire.
I don't think it's a oom problem : a user tested with only 1 single
widget after a reboot, and same problem.

I think if you can flash a Desire HD ROM on a normal Desire, the
problem should occur.

2010/11/8 Ander Web <ande...@gmail.com>:

[Florian Sundermann]

Hi,

2010/11/8 Francois DESLANDES <kox...@gmail.com>:

> I think if you can flash a Desire HD ROM on a normal Desire, the
> problem should occur.

Seems so: http://forum.xda-developers.com/showthread.php?t=789830

I will have a look at it (and give feedback) as soon as possible...

[Florian Sundermann]

Good news everyone: I can reproduce the bug with agendawidget and ADW.
But there is no FC. it just looks weird and produces a log msg...

I go for a smoke and then do some testing...
BTW: Desire is to slow with Desire HD rom...

Regards
Florian

2010/11/8 Florian Sundermann <boom...@googlemail.com>:

[Florian Sundermann]

Francois I guess it's your code: can we use

InputStream rawResource = ctx.getResources().openRawResource( imgId);
drawable = Drawable.createFromStream(rawResource,
ctx.getResources().getResourceName(imgId));

instead of the original code? cause It seem to work for me...

Regards
Florian

[Francois DESLANDES]

Yes, sure :)

2010/11/9 Florian Sundermann <boom...@googlemail.com>:

[rofl harrison]

According  to my users with Desire HD units this patch fixes the problem (tested with a new build of ADW).

Nice work Florian!

[Florian Sundermann]

Ok,

gonna commit this as soon as I am home to the trunk and the testing branch...

[Francois DESLANDES]

Yes, thank you very much Florian ! :)

2010/11/9 Florian Sundermann <boom...@googlemail.com>:

[Florian Sundermann]

Just commited the changes to trunk / testing branch for L+ and to my
fixes branch for ADW.

So everyone should update their launcher code ;-)

[Florian Sundermann]

Just fixed another FC at the testing branch!