Bug Correction

5 views
Skip to first unread message

fabien....@gmail.com

unread,
May 22, 2010, 8:35:42 PM5/22/10
to and...@googlegroups.com
A few bug corrections to make it run on my own android phone.

Thanks

--
Fabien Carrion

() Campagne du ruban ASCII -- Contre les mails en html
/\ contre les pieces-jointes Microsoft
Web: http://fabien.carrion.free.fr/
osm.patch.zip

valentin.blot0

unread,
May 23, 2010, 8:08:19 AM5/23/10
to AndNav
The URL for openpistemap tiles had already been pointed out, now it's
been commited. Thanks. But concerning the file src/org/andnav2/osm/
views/util/LRUMapTileCache.java, your change seems strange... Could
you explain how you get the bug ? And on which phone and android
version ? Thanks.

Valentin

On 23 mai, 02:35, "fabien.carr...@gmail.com"
>  osm.patch.zip
> < 1 000AfficherTélécharger

fabien....@gmail.com

unread,
May 24, 2010, 11:27:22 AM5/24/10
to and...@googlegroups.com
On the nexus one, android 2.1, when I display the map, each tile of
the map keep reloading again and again.

After the modification in LRUMapTileCache, every thing went fine.

Thanks

valentin.blot0

unread,
May 24, 2010, 5:32:33 PM5/24/10
to AndNav
Very strange, but making the modification you suggest would lead to a
behaviour which is not the one intended. Please try to apply this
patch and tell me if it corrected the bug :

Index: LRUMapTileCache.java
===================================================================
--- LRUMapTileCache.java (révision 46)
+++ LRUMapTileCache.java (copie de travail)
@@ -119,7 +119,8 @@
* @param key of the value to move to the top of the
list

*/
private void updateKey(final String key)
{
-
this.list.remove(key);
+ if
(super.containsKey(key))
+
this.list.remove(key);

this.list.addFirst(key);
}

Valentin

On 24 mai, 17:27, "fabien.carr...@gmail.com"

fabien....@gmail.com

unread,
May 24, 2010, 6:39:51 PM5/24/10
to and...@googlegroups.com
That's doing the same error. Each tile is reloading again and again.

Thanks

valentin.blot0

unread,
May 24, 2010, 8:05:28 PM5/24/10
to AndNav
I committed a fix for your issue. Please try it and tell me if it's
ok. The issue seems to be the high-res of the nexus one which permits
more tiles to be displayed on one screen, so I had to increase the
size of the tile cache.

Valentin

On 25 mai, 00:39, "fabien.carr...@gmail.com"

fabien....@gmail.com

unread,
May 25, 2010, 10:24:42 AM5/25/10
to and...@googlegroups.com
That's working now.

Thanks!!
Reply all
Reply to author
Forward
0 new messages