Some doubts

[fabien....@gmail.com]

Hello,

I have some doubts on the application.

On my nexus one,

When I first launch the map activity during the first 5 sec, if I want
to move the map, it is only moving half of the map. Then every thing
goes back to normality.
The second doubt I have is the same like the first one, but it is for
rotation. When the map is rotated, it only rotates half of the map and
then it rotates it fully.

Would it be because of the high resolution of the nexus again?

I attached the last version of my patch to zoom and rotate with multitouch.

Thanks

--
Fabien Carrion

() Campagne du ruban ASCII -- Contre les mails en html
/\ contre les pieces-jointes Microsoft
Web: http://fabien.carrion.free.fr/

[valentin.blot0]

I have the same bug so it's not because of high resolution. I'll try
to fix it when I have some time, maybe you can post it as an issue on
the googlecode page ?

Valentin

On 29 mai, 16:38, "fabien.carr...@gmail.com"

>  multitouchzoomrotate.patch.zip
> 3KAfficherTélécharger

[valentin.blot0]

Concerning the multitouch, this seems to be a very good feature but I
didn't integrate it yet for two reasons : firstly I can't test it, I
wouldn't want to add bugs before the release, and secondly it uses
android 2.1, so andnav would become uncompatible with earlier
versions. A solution would be to create a new branch, but since that
means two versions of andnav on the market, I let Nicolas decide on
this.

Valentin

[Neil]

There is also a multitouch fix in osmdroid. It doesn't work yet, but
it uses reflection so that it doesn't require 2.1. Hopefully we can
combine a fix that uses reflection and works.

http://code.google.com/p/osmdroid/issues/detail?id=25

Neil

[fabien....@gmail.com]

Thanks for the link. That's implemented in this patch.

Zoom is working very well now.
Rotation still has some problems, because of the few clipping problems
I notice earlier.

Let me know...

[valentin.blot0]

reflect seems to be a good solution to keep andnav2 working on earlier
android versions. As I cannot test the multitouch, could you post the
patch when you have fixed the bug with rotation ?
Thanks.

Valentin

On 31 mai, 21:30, "fabien.carr...@gmail.com"

>  multitouchmap.patch.zip
> 3KAfficherTélécharger

[fabien....@gmail.com]

I would be partisan of doing two patch. One with the zoom working ok
so you can integrate it quickly.

Then when I'll have the rotation working, I'll send you an another patch. ok ?

[fabien....@gmail.com]

Ok here is a patch with multitouch only for zooming.

Thanks

[Neil]

Some comments on the coding style:

Why bother making id, first and second int? Just keep them as Objects
and it saves a lot of conversion.

Why do this: new Float((float)event.getX())? You can just use
event.getX() directly.

Why call .floatValue()? You can just do autoboxing again.

I didn't quite get the point of the two HashMaps. Are they remnants of
the rotation?


And the same comment I made for osmdroid: Wouldn't it be better to do
the zoom on mouse up rather than move?



On Jun 1, 3:37 pm, "fabien.carr...@gmail.com"

<fabien.carr...@gmail.com> wrote:
> Ok here is a patch with multitouch only for zooming.
>
> Thanks
>

> On Tue, Jun 1, 2010 at 8:09 AM, fabien.carr...@gmail.com

>
>
>
>
>
> <fabien.carr...@gmail.com> wrote:
> > I would be partisan of doing two patch. One with the zoom working ok
> > so you can integrate it quickly.
>
> > Then when I'll have the rotation working, I'll send you an another patch. ok ?
>

>  multitouchzoom.patch.zip
> 2KViewDownload

[fabien....@gmail.com]

Hello,

On Tue, Jun 1, 2010 at 10:02 AM, Neil <neil...@gmail.com> wrote:
> Some comments on the coding style:
>
> Why bother making id, first and second int? Just keep them as Objects
> and it saves a lot of conversion.

corrected

> Why do this: new Float((float)event.getX())? You can just use
> event.getX() directly.

corrected

> Why call .floatValue()? You can just do autoboxing again.

corrected

> I didn't quite get the point of the two HashMaps. Are they remnants of
> the rotation?

corrected

> And the same comment I made for osmdroid: Wouldn't it be better to do
> the zoom on mouse up rather than move?

Correct me if I am wrong but in the default browser from android, the
zoom is done on mouse move.

Thanks for the comments

[Neil]

I still don't know what the point of the HashMap is :-/ Perhaps you
could explain in. The way it's done in osmdroid looks simpler.

ACTION_POINTER_ID_SHIFT is deprecated in favour of
ACTION_POINTER_INDEX_SHIFT, and the initial value should be 8.

You're probably right about zooming on move. The Google Maps app has a
continuous zoom which then settles to a better value on mouse up.

There's some unused variables - centerX, centerY and parent.

Anyway, I think it's someone else's turn to say something ;-)

Neil

http://L6n.org/android/


On Jun 2, 2:08 am, "fabien.carr...@gmail.com"
<fabien.carr...@gmail.com> wrote:
> Hello,

>  multitouchzoom.patch.zip
> 2KViewDownload

[Valentin Blot]

I made a few changes to your patch, here is the modified version. Could you
test it and tell me if multitouch still works (I cannot test it).
Thanks.

Valentin

[Fabien Carrion]

I like this patch. It is working for me.

+1 for commit

Thanks

>>>>>>>>>>>> 3KAfficherT�l�charger

>>>>>>>> --
>>>>>>>> Fabien Carrion
>>>>>>>> () Campagne du ruban ASCII -- Contre les mails en html
>>>>>>>> /\ contre les pieces-jointes Microsoft
>>>>>>>> Web:http://fabien.carrion.free.fr/
>>>>>>>> multitouchmap.patch.zip

>>>>>>>> 3KAfficherT�l�charger

>>>>>> --
>>>>>> Fabien Carrion
>>>>>> () Campagne du ruban ASCII -- Contre les mails en html
>>>>>> /\ contre les pieces-jointes Microsoft
>>>>>> Web:http://fabien.carrion.free.fr/
>>>>> --
>>>>> Fabien Carrion
>>>>> () Campagne du ruban ASCII -- Contre les mails en html
>>>>> /\ contre les pieces-jointes Microsoft
>>>>> Web:http://fabien.carrion.free.fr/
>>>>> multitouchzoom.patch.zip
>>>>> 2KViewDownload
>>> --
>>> Fabien Carrion
>>> () Campagne du ruban ASCII -- Contre les mails en html
>>> /\ contre les pieces-jointes Microsoft
>>> Web:http://fabien.carrion.free.fr/
>>> multitouchzoom.patch.zip
>>> 2KViewDownload

--

[valentin.blot0]

Commited

Valentin