Proposition for some changes

[valentin.blot0]

Hello,

I'm quite new here but I'm using AndNav2 since a few weeks now and I
corrected a few bugs that prevented me from compiling the svn version
on eclipse. The three changes are :
- the 's in eula.xml
- the lack of <uses-permission
android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> in
AndroidManifest.xml
- the adding of the TTS library in the lib directory

My first question is : is it OK if I commit these changes ?

Other question :
Since the 1.5 version is also working on 1.6 and 2.1, and since the
1.6 and 2.1 versions do not have special improvements (correct me if
I'm wrong), is this really useful to have different branches ?
Couldn't we keep only the "trunk" (and the "tags" of course) ? (easier
to manage)

Other question :
The servers for resolving address search and route calculation seem to
be down since quite a long time... Will the server work again in the
future or should we just take away these functionalities ?

Other question :
Since this software is now open source shouldn't we take away the
ads ? Same question for paypal.

Last question :
Is there a reason for GoogleMaps being disabled in navigation mode ?
Is there a law issue ?

Thank you for your replies.

Valentin

[valentin.blot0]

Hi,

I received no reply so I made the first changes, I also removed some
branches (I only kept the "pinned-entity-refactor" one, by the way,
phreed, if you read this, are you going to work again on this
branch ?).

I added the new server to the list, I will probably remove the others
in the next commit.

The question about the ads and paypal remains...

The one on GoogleMaps too...

Valentin

[Nicolas Gramlich]

I'd like to keep the ads 

The permission you suggested should be in, but if I remember correctly it was introduced after 1.6 ?!

I cannot really say if there were some special improvements to the "> 1.5" branches as I didn't follow the commits closely.

Yes GoogleMaps must be disabled in navigation mode for legal issues. The ToS is like "there must not be a route shown on GoogleMaps with a Geolocation that is updating itself" or so.

Best Regards,

Nicolas

[valentin.blot0]

Ok for the ads, I don't remove it.

For the permission, I didn't see it anywhere, even in the latest
revisions.

Actually I checked the changes before deleting the branches, and I
merged it to the trunk.

OK for GoogleMaps, I keep it as it is.

Valentin

On 20 mai, 17:16, Nicolas Gramlich <nicolasgraml...@gmail.com> wrote:
> I'd like to keep the ads [?]

>
> The permission you suggested should be in, but if I remember correctly it
> was introduced after 1.6 ?!
>
> I cannot really say if there were some special improvements to the "> 1.5"
> branches as I didn't follow the commits closely.
>
> Yes GoogleMaps must be disabled in navigation mode for legal issues. The ToS
> is like "there must not be a route shown on GoogleMaps with a Geolocation
> that is updating itself" or so.
>
> Best Regards,
> Nicolas
>

>  347.gif
> < 1 000AfficherTélécharger

[phreed]

> I received no reply so I made the first changes, I also removed some
> branches (I only kept the "pinned-entity-refactor" one, by the way,
> phreed, if you read this, are you going to work again on this
> branch ?).

I've changed my approach, so I probably won't be working on that
branch.

[valentin.blot0]

Ok, I removed the branch then, so now evryone should be working on the
trunk, except if one wants to add a new feature, and in this case
there should be periodical merges with the trunk (I tried to merge the
"pinned-entity-refactor" branch, but it was really messy since it was
too different from trunk).