Re: [amora commit] r484 - trunk/amora-server/src

0 views
Skip to first unread message

Ademar de Souza Reis Jr.

unread,
Feb 21, 2008, 9:12:23 AM2/21/08
to amora...@googlegroups.com
WTF?

On Thu, Feb 21, 2008 at 2:53 AM, <codesite...@google.com> wrote:
> Author: cavalcantii
> Date: Wed Feb 20 21:53:04 2008
> New Revision: 484
>
> Modified:
> trunk/amora-server/src/dbus.c
>
> Log:
> Sanitize bad wording.
>
>
>
> Modified: trunk/amora-server/src/dbus.c
> ==============================================================================
> --- trunk/amora-server/src/dbus.c (original)
> +++ trunk/amora-server/src/dbus.c Wed Feb 20 21:53:04 2008
> @@ -157,7 +157,7 @@
> dbus_message_get_args(msg, NULL, DBUS_TYPE_STRING,
> &path, DBUS_TYPE_INVALID);
>
> - /* basename() systax is fscking ugly */
> + /* basename() systax is awful ugly */
> basec = strdup(path);
> bname = basename(basec);
>
>

--
Ademar de Souza Reis Jr. <ade...@ademar.org>
http://www.ademar.org/
http://blog.ademar.org/

^[:wq!

Thiago Marcos P. Santos

unread,
Feb 21, 2008, 10:52:31 AM2/21/08
to amora...@googlegroups.com

Ademar de Souza Reis Jr.

unread,
Feb 21, 2008, 11:54:51 AM2/21/08
to amora...@googlegroups.com
My point is: why remove this from the code? It's a very common word,
used extensively in any kind of hacker conversations and in open
source projects...

IOW, why consider it "bad language" and why the necessity to
"sanitize" the code? Is it a matter of personal taste or are there
other reasons? :-)

Regards,
- Ademar

caval...@gmail.com

unread,
Feb 21, 2008, 8:03:17 PM2/21/08
to Amora Developers
Ademar

No need to get your tinfoil hat now... Last night we were drinking
some
ale and Thiago had said that he left a 'fsck' in a source code
commentary (and
I decided to play a joke and remove it from the repository).

Thank god that my notebook doesn't have a breath alcohol tester on
that night...

As a matter of fact, just try to run this in the tablet amora
directory:
svn blame amora | grep "fucker"

Or even better, try to execute the tamora client and look to the
output...

But, I do think it is advisable try to retrain the use of bad wording
when commenting the source code (its more professional).


Best regards


Adenilson

Ademar de Souza Reis Jr.

unread,
Feb 21, 2008, 8:20:00 PM2/21/08
to amora...@googlegroups.com
hehe... it's good to know that. :-)

I hope you don't drink enough to eventually decide to put a system("rm
-rf /") somewhere
in the source code. ;-)

Best regards,
- Ademar

--

caval...@gmail.com

unread,
Feb 22, 2008, 1:15:03 PM2/22/08
to Amora Developers
Ademar

Of course not! I would use 'execvp' instead...

Regards


Adenilson

On Feb 21, 9:20 pm, "Ademar de Souza Reis Jr." <ademar.r...@gmail.com>
wrote:
Reply all
Reply to author
Forward
0 new messages