Is this project still maintained?

48 views
Skip to first unread message

Jan Persson

unread,
Aug 11, 2011, 8:56:59 AM8/11/11
to amf...@googlegroups.com
Hi,

I just discovered AmFast and it seems to be an excellent library. I
plan to use it together with gevent and bottle for a Flex application
I am developing.
However, it seems like there has not been much activity lately, so I'm
wondering if the project is still maintained and if you would accept
patches?

Best Regards
//Jan Persson

--
Jan Persson - Esentus Technology AB - www.esentus.com - +46 702 854132 (mobile)

limscoder

unread,
Aug 12, 2011, 10:07:22 AM8/12/11
to AmFast
Hi Jan,

I no longer work on the project I originally created AmFast for, so I
don't have time for new feature development. However, I try to find
time to fix any bugs that come up, and I am more than happy to review
and merge patches.

-Dave

Jan Persson

unread,
Aug 12, 2011, 10:41:19 AM8/12/11
to amf...@googlegroups.com
Hi,

Thanks for the answer. That sounds good.

I think I have the found a bug. I am using messaging in connection
with the wsgi_channel and my logs were full of messages like this:

192.168.1.100 - - [2011-08-12 16:30:57] "POST /amf HTTP/1.1" 200 660 0.003478
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/gevent-0.13.6-py2.7-linux-x86_64.egg/gevent/pywsgi.py",
line 438, in handle_one_response
self.run_application()
File "/usr/local/lib/python2.7/dist-packages/gevent-0.13.6-py2.7-linux-x86_64.egg/gevent/pywsgi.py",
line 425, in run_application
self.process_result()
File "/usr/local/lib/python2.7/dist-packages/gevent-0.13.6-py2.7-linux-x86_64.egg/gevent/pywsgi.py",
line 414, in process_result
for data in self.result:
TypeError: 'NoneType' object is not iterable
<WSGIServer fileno=4 address=0.0.0.0:8000>: Failed to handle request:
request = POST
/amf?command=close&streamId=024838ba-db13-4542-9096-f50ef95758d2&version=1
HTTP/1.1 from ('192.168.1.100', 58094)
application = <werkzeug.wsgi.DispatcherMiddleware object at 0x2e12c10>

So it looks like StreamingWsgiChannel is not handling the
CLOSE_COMMAND correctly. The code that handles these messages looks
like this:

if msg.operation == msg.CLOSE_COMMAND:
return self.stopStream(msg)

But stopStream does not return anything, which makes __call__ return
None up in the WSGI chain.

So my patch look like this, but please bear in mind that I'm new to
this library and might have misunderstood this behavior completely.

--- /home/jpersson/amfast-read-only/amfast/remoting/wsgi_channel.py 2011-08-06
23:24:14.490363454 +0200
+++ wsgi_channel.py 2011-08-11 14:39:17.460029795 +0200
@@ -277,3 +277,5 @@
connection.disconnect()
if hasattr(connection, "notify_func") and
connection.notify_func is not None:
connection.notify_func()
+ return []
+

Cheers
//Jan Persson

> --
> You received this message because you are subscribed to the Google Groups "AmFast" group.
> To post to this group, send email to amf...@googlegroups.com.
> To unsubscribe from this group, send email to amfast+un...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/amfast?hl=en.
>
>

--

limscoder

unread,
Aug 14, 2011, 7:35:40 PM8/14/11
to AmFast
Your change looks good. It's in trunk now.

On Aug 12, 8:41 am, Jan Persson <jan.pers...@gmail.com> wrote:
> Hi,
>
> Thanks for the answer. That sounds good.
>
> I think I have the found a bug. I am using messaging in connection
> with the wsgi_channel and my logs were full of messages like this:
>
> 192.168.1.100 - - [2011-08-12 16:30:57] "POST /amf HTTP/1.1" 200 660 0.003478
> Traceback (most recent call last):
>   File "/usr/local/lib/python2.7/dist-packages/gevent-0.13.6-py2.7-linux-x86_64.eg g/gevent/pywsgi.py",
> line 438, in handle_one_response
>     self.run_application()
>   File "/usr/local/lib/python2.7/dist-packages/gevent-0.13.6-py2.7-linux-x86_64.eg g/gevent/pywsgi.py",
> line 425, in run_application
>     self.process_result()
>   File "/usr/local/lib/python2.7/dist-packages/gevent-0.13.6-py2.7-linux-x86_64.eg g/gevent/pywsgi.py",
> >> Jan Persson - Esentus Technology AB -www.esentus.com-+46 702 854132 (mobile)
>
> > --
> > You received this message because you are subscribed to the Google Groups "AmFast" group.
> > To post to this group, send email to amf...@googlegroups.com.
> > To unsubscribe from this group, send email to amfast+un...@googlegroups.com.
> > For more options, visit this group athttp://groups.google.com/group/amfast?hl=en.
>
> --
Reply all
Reply to author
Forward
0 new messages