Testing Amara2

0 views
Skip to first unread message

Luis Miguel Morillas

unread,
Oct 22, 2008, 4:55:53 PM10/22/08
to amar...@googlegroups.com
I've pushed my first amara2/tests/bindery/mutation.py version (not finished).
Review it uche, please

I've got two questions about it.

* Amara2' bindery nodes haven't got the old .xml() method. Must we use
xml_print function better?
* How to add a raw text to a bindery node? Amara1 had a
.xml_append_fragment() method, but Amara2 has not it. I'm using a
node.xml_append(bindery.parse(raw_xml_string).xml_children[0]) walk
around. Is it correct?

Regards,

--

Luis Miguel

Uche Ogbuji

unread,
Oct 22, 2008, 5:27:33 PM10/22/08
to amar...@googlegroups.com
I'll review. Thanks. I just wanted to record for the list what we
discussed on the Jabber channel.

Luis Miguel Morillas wrote:
> I've pushed my first amara2/tests/bindery/mutation.py version (not finished).
> Review it uche, please
>
> I've got two questions about it.
>
> * Amara2' bindery nodes haven't got the old .xml() method. Must we use
> xml_print function better?
>

Yeah, it's on Jeremy's list to add the xml_print() method to core tree
nodes. For now let's write the tests using amara.xml_print(node), and
update when node.xml_print() is available.

> * How to add a raw text to a bindery node? Amara1 had a
> .xml_append_fragment() method, but Amara2 has not it. I'm using a
> node.xml_append(bindery.parse(raw_xml_string).xml_children[0]) walk
> around. Is it correct?
>

I'll fix that for bindery nodes now. We'll have to see whether Jeremy
wants to add such a method at the core tree level.

--
Uche Ogbuji http://uche.ogbuji.net
Founding Partner, Zepheira http://zepheira.com
Linked-in profile: http://www.linkedin.com/in/ucheogbuji
Articles: http://uche.ogbuji.net/tech/publications/

Uche Ogbuji

unread,
Oct 23, 2008, 7:44:55 PM10/23/08
to amar...@googlegroups.com
Uche Ogbuji wrote:
>> * How to add a raw text to a bindery node? Amara1 had a
>> .xml_append_fragment() method, but Amara2 has not it. I'm using a
>> node.xml_append(bindery.parse(raw_xml_string).xml_children[0]) walk
>> around. Is it correct?
>>
>>
>
> I'll fix that for bindery nodes now. We'll have to see whether Jeremy
> wants to add such a method at the core tree level

Done.

Luis Miguel Morillas

unread,
Oct 26, 2008, 5:29:17 AM10/26/08
to amar...@googlegroups.com
Hi, uche

2008/10/24 Uche Ogbuji <uc...@ogbuji.net>:


>
> Uche Ogbuji wrote:
>>> * How to add a raw text to a bindery node? Amara1 had a
>>> .xml_append_fragment() method, but Amara2 has not it. I'm using a
>>> node.xml_append(bindery.parse(raw_xml_string).xml_children[0]) walk
>>> around. Is it correct?
>>>
>>>
>>
>> I'll fix that for bindery nodes now. We'll have to see whether Jeremy
>> wants to add such a method at the core tree level
>
> Done.
>

You haven't pushed your changes, have you?


Saludos,

--

Luis Miguel

Uche Ogbuji

unread,
Oct 26, 2008, 9:23:24 AM10/26/08
to amar...@googlegroups.com
Luis Miguel Morillas wrote:
> 2008/10/24 Uche Ogbuji <uc...@ogbuji.net>:
>
>> Uche Ogbuji wrote:
>>
>>>> * How to add a raw text to a bindery node? Amara1 had a
>>>> .xml_append_fragment() method, but Amara2 has not it. I'm using a
>>>> node.xml_append(bindery.parse(raw_xml_string).xml_children[0]) walk
>>>> around. Is it correct?
>>>>
>>> I'll fix that for bindery nodes now. We'll have to see whether Jeremy
>>> wants to add such a method at the core tree level
>>>
>> Done.
>>
>
> You haven't pushed your changes, have you?
>

You're right. I was missing a message that I needed a merge. Looks
like Jeremy's been busy too. He checked in a bunch of XSLT fixes :)

Thanks.

Reply all
Reply to author
Forward
0 new messages