What would be the best way to submit my theme for possible release with the next revision of Alt-F? I only have 1 bug in this theme that I am stuck with trying to fix, other then that, I have completely tested the theme on my DNS-325, and every thing is working as should be expected. Including all of the CSS, Font Awesome, new files, and the functionality of all of the pages, and features. Everything works as it should.
The responsive and a bug with the Logo Image are the two places in which I could use a hand fixing, however, anyone using this theme, the logo can be removed which will solve one of the bugs leaving just the responsive coding is all that I can't get to work right.
So if I remove the code for my Branded Logo, that removes one of the few hurdles. Everything else works perfectly. While I recall you saying that you might include my theme if it was just a color change and no mahot changes, the Font Awsome really brings the new theme together and I would like to leave them in if possible. If you would prefer I create a version where just the color chnages are there, and I remove the Font Awespme, I can do that.
Since I am not to familiar with how to check code in to Git, I can provide all the files to whom ever would like them (the *thm, css, html, and js files) where the changes are made, I can do so, just let me know where to send them since zip files are not acceptable via Google Groups.
Joao,When you say lisence which are you referring to?
# XXX is free software: you can redistribute it and/or modify | |
# it under the terms of the GNU General Public License as published by | |
# the Free Software Foundation, either version 3 of the License, or | |
# (at your option) any later version. | |
# XXX is distributed in the hope that it will be useful, | |
# but WITHOUT ANY WARRANTY; without even the implied warranty of | |
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
# GNU General Public License for more details. | |
# You should have received a copy of the GNU General Public License | |
# along with xxx. If not, see <http://www.gnu.org/licenses/>. |
Forgive my being nieve here, but this is the first time I have ever had the oppurtunity to write any code that could be considered as part of someone elses project or that of any project to be honest. So I am not sure which licensing I need to cover. My code would be considered under the GNU Open Source lisensing as I would want this to be open to anyone wanting to make their won changes should they choose.
Question - Since I have made changes to the Help Files, as well as adding a new CSS file for the Help.html files, is there a way for me to include this in a zip that can be installed using the Theme intaller on the Utilitoes Page?
Or do I need to create a way to manually install them?ORCan I supply you
with the files (I can check them into Git (if I can figure out how to do this since I have never done that before) and you could somehow incorporate them somehow in a future version should there be one?Sadly for me, I have never used Git for saving any project, I have only every used it to grab code to compile for my own use, so this is all very new to me. I would like to do things the right way and the best way so that everyone can enjoy this theme should they decide to use it.
On Wednesday, May 1, 2019 at 3:03:51 PM UTC+1, eutopian...@gmail.com wrote:Joao,When you say lisence which are you referring to?Hope you are asking in good faith, although you could ask Google first :-)Essentially its a two line commented wording in your code saying that you are the author, and under what conditions it can be used (like when you accept sites to use cookies). Like# This file is covered by the XXX License, available at http://public.locationSome recommend explicitly refereinv the licence, such as
# XXX is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation, either version 3 of the License, or # (at your option) any later version. # XXX is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # You should have received a copy of the GNU General Public License # along with xxx. If not, see <http://www.gnu.org/licenses/>. If you say nothing, it will be considered to be in the Public Domain, although some say that such thing doesn't exists... its complicated and layer territory.There are also some creative licences, such as WTFPL "Do what the fu*** you want to Public License" https://en.wikipedia.org/wiki/WTFPL
Luckily I thought well enough ahead and saved all the code and changes to my NAS, so I didn't lose any of the code changes just the Readme and in st ll I syructions which I will rewrite.
Based on the way Toast wrote write his Lisence witb the MIT Lisence I used the same giving him credit as the orig author and only the image that I added is the only file which I have required that that single image may be used but not edited or modified in any way but use got personal or commercial use is perfectly fine. The rest I have left under the MIT Lisence as was done with the original code.
So others can check out and use the theme to see if they like it I will also zip it up and either add it to this thread or I will create a new clean thread with the, zip (containing the .thm, new directory containing all the css, js files required for the theme. I will create a separate zip file containing the new css file and all the help.html files that have all been changed to use the new css to keep the styling in line.
I hope that this will be ok, again this is all very new for me, while writing code is not, I've only ever written code in a corporate environment which we had our own repository (rcs) so using Git and or source forage is extremely alien to me.
I definitely want to do things the right way and I'm sure I wdill mess 8t up somewhere and hopefully you guys will be gentle when yling me I'm an idiot with the way I've uploaded everything lol.
I appreciate your understanding and patience with me. It's a steep learning curve for me, but I'm doing the best I can to do it correctly.
Thanks.
John