Issue 5 in alfresco-opencmis-extension: Aggregating aspect property definitions

[alfresco-opencmis-exte...@codespot.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 5 by agood...@wingspan.com: Aggregating aspect property
definitions
http://code.google.com/a/apache-extras.org/p/alfresco-opencmis-extension/issues/detail?id=5

What steps will reproduce the problem?
1. Fetch an object with one or more aspects attached
2. Call CmisObject.getType()
3. Call ObjectType.getPropertyDefinitions()

What is the expected output? What do you see instead?
I expect to see the property definitions for the attached aspects; instead,
I see only the definitions for the type.

What version of the product are you using? On what operating system?
extension 0.2 with Apache Chemistry 0.5, Alfresco Community 3.4

Please provide any additional information below.
Attached a zip with the patch.

Attachments:
alfresco-extn-patch.zip 5.5 KB

[alfresco-opencmis-exte...@codespot.com]

Updates:
Owner: floria...@gmail.com
Labels: -Type-Defect Type-Enhancement

Comment #1 on issue 5 by floria...@gmail.com: Aggregating aspect property
definitions
http://code.google.com/a/apache-extras.org/p/alfresco-opencmis-extension/issues/detail?id=5

(No comment was entered for this change.)

[alfresco-opencmis-exte...@codespot.com]

Updates:
Status: Fixed

Comment #2 on issue 5 by floria...@gmail.com: Aggregating aspect property
definitions
http://code.google.com/a/apache-extras.org/p/alfresco-opencmis-extension/issues/detail?id=5

The patch changes the behaviour of existing methods and might jeopardize
application using it
I have added a getTypeWithAspects() method instead.

[alfresco-opencmis-exte...@codespot.com]

Comment #3 on issue 5 by agood...@wingspan.com: Aggregating aspect property
definitions
http://code.google.com/a/apache-extras.org/p/alfresco-opencmis-extension/issues/detail?id=5

I think adding a new method, getTypeWithAspects, is not ideal because
there's no corresponding "getPropertiesWithAspects". It makes the
programming model asymmetric: not all the properties returned in
getProperties are described by the type from getType.

How about instead a session flag (param) to control whether getType returns
the combined type info? It can default to false so that existing users are
not affected.