Issue 291 in alembic: Alembic 1.1.0 does not compile on Windows

[ale...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect FoundBy-Community

New issue 291 by shinc...@gmail.com: Alembic 1.1.0 does not compile on
Windows
http://code.google.com/p/alembic/issues/detail?id=291

What steps will reproduce the problem?
1. Download Alembic 1.1.0
2. Compile Alembic 1.1.0
3. Build errors

What is the expected output? What do you see instead?
2 build errors.

What version of the product are you using? On what operating system?
Alembic 1.1.0

Please provide any additional information below.
1) OMaterial.cpp, line 130
"interface" is a MSVC reserved token. Please rename "interface" member
variable.

2) TimeSamplingType.cpp, line 46
std::numeric_limits::max() conflicts with max() in windows.h
Please define NOMINMAX before include Windows.h in Alembic/Util/Foundation.h

Thanks~

[ale...@googlecode.com]

Comment #1 on issue 291 by shinc...@gmail.com: Alembic 1.1.0 does not

compile on Windows
http://code.google.com/p/alembic/issues/detail?id=291

btw, in alembic_bootstrap.py line 250, libdir is assigned twice.
The second assignment is boost python.
If I build alembic without python, libdir is always "." and cmake complains
it can't find boost.

[ale...@googlecode.com]

Updates:
Status: PleaseVerify
Owner: miller.lucas

Comment #2 on issue 291 by miller.lucas: Alembic 1.1.0 does not compile on
Windows
http://code.google.com/p/alembic/issues/detail?id=291

http://code.google.com/r/millerlucas-dev/source/detail?r=1e222facd09dad2a33a7e5bd432d1bc7c3cb578c

http://code.google.com/r/millerlucas-dev/source/detail?r=96aa5a13380ed9f95a02c73f9b6f62b12aacf2f2

Attempts to deal with the your initial comments. Could you try it out?

[ale...@googlecode.com]

Comment #3 on issue 291 by axelgnei...@gmail.com: Alembic 1.1.0 does not

compile on Windows
http://code.google.com/p/alembic/issues/detail?id=291

iirc. I solved this by defining WIN32_LEAN_AND_MEAN

[ale...@googlecode.com]

Comment #4 on issue 291 by shinc...@gmail.com: Alembic 1.1.0 does not

compile on Windows
http://code.google.com/p/alembic/issues/detail?id=291

The 2 changes solved the build errors.
I can now build successfully with VC9/VC10+x86/amd64 combinations.
Thanks.

[ale...@googlecode.com]

Comment #5 on issue 291 by shinc...@gmail.com: Alembic 1.1.0 does not

compile on Windows
http://code.google.com/p/alembic/issues/detail?id=291

In CentOS5+gcc4.1.2 environment, there is a warning in
Alembic/AbcCoreHDF5/ArImpl.cpp line 211.
warning: passing NULL to non-pointer argument 2 of 'ssize_t
H5Aget_name(hid_t, size_t, char*)'.
Not a big issue but warning-as-error stops my build.

[ale...@googlecode.com]

Comment #6 on issue 291 by miller.lucas: Alembic 1.1.0 does not compile on
Windows
http://code.google.com/p/alembic/issues/detail?id=291

Thanks, the logic in the section that was being warned about had a few more
issues than just the warning.

Fortunately that code would only get run if the HDF5 Attrs weren't being
properly cleaned up in the rest of the code.

Here is a much better fix:
http://code.google.com/r/millerlucas-dev/source/detail?r=3c842a49419b8e90e2f98a2d40bddd69edff2c03

[ale...@googlecode.com]

Comment #7 on issue 291 by shinc...@gmail.com: Alembic 1.1.0 does not

compile on Windows
http://code.google.com/p/alembic/issues/detail?id=291

When I was trying to integrate AbcImport and AbcExport, I found our
building system force to define NOMINMAX by compiler command line
arguments. I got a macro redefinition warning.. Could you wrap the define
with ifndef like:
#ifndef NOMINMAX
#define NOMINMAX
#endif

Thank you again!

[ale...@googlecode.com]

Comment #8 on issue 291 by miller.lucas: Alembic 1.1.0 does not compile on
Windows
http://code.google.com/p/alembic/issues/detail?id=291

Yeah, that isn't controversial:

http://code.google.com/r/millerlucas-dev/source/detail?r=fbbd1b9e530b0ae66b986d51223edef51f97c9ff