Re: [aldor] genjava: It is possible for a (Values (...)) statement to be left lying (0800f83)

2 views
Skip to first unread message

Ralf Hemmecke

unread,
Sep 25, 2014, 6:50:30 AM9/25/14
to aldor-devel
I've also seen spaces introduced at the end of the line.
Should be avoided, I think.

For example, here...
https://github.com/pippijn/aldor/commit/b95b9854879a03515fc7a4328efb93f4cded8be0#diff-fb0cf14f7735c0dd1caf5ac977192b39R96

Maybe exactly that is what Pippijn is asking.

Ralf

On 09/25/2014 12:10 PM, Pippijn van Steenhoven wrote:
> nit: spaces around binary operators.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/pippijn/aldor/commit/0800f83eaac54da02ccb058aed6bc15f4f9aa45b#commitcomment-7920682
>

Pippijn van Steenhoven

unread,
Sep 25, 2014, 9:30:54 AM9/25/14
to Ralf Hemmecke, aldor-devel
On Thu, Sep 25, 2014 at 12:50:29PM +0200, Ralf Hemmecke wrote:
> I've also seen spaces introduced at the end of the line.
> Should be avoided, I think.

Yes, that is exactly what I was commenting on.
signature.asc
Reply all
Reply to author
Forward
0 new messages