[Akelos PHP Framework] #267: Nested Render Partial Collection: miss object within nested, and fail when collection is empty

1 view
Skip to first unread message

Akelos PHP Framework

unread,
Aug 31, 2009, 2:49:28 AM8/31/09
to
#267: Nested Render Partial Collection: miss object within nested, and fail when
collection is empty
----------------------------------------------+-----------------------------
Reporter: firodj | Type: patch
Status: new | Priority: major
Milestone: 1.0 | Component: Action Controller
Keywords: nested render partial collection |
----------------------------------------------+-----------------------------
I made a PATCH for render partial collection:
* wrong assigned `$object` vars when using as nested partial
* failed when `$collection` is empty array
But, I didnt make a test for them.

--
Ticket URL: <http://trac.akelos.org/ticket/267>
Akelos PHP Framework <http://www.akelos.org/>
Akelos PHP Framework

Akelos PHP Framework

unread,
Sep 21, 2009, 9:25:14 AM9/21/09
to
#267: Nested Render Partial Collection: miss object within nested, and fail when
collection is empty
----------------------------------------------+-----------------------------
Reporter: firodj | Owner:
Type: patch | Status: new
Priority: major | Milestone: 1.0
Component: Action Controller | Resolution:
Keywords: nested render partial collection |
----------------------------------------------+-----------------------------
Comment (by firodj):

1. Nested partial with empty() object:
{{{
$Template->render(array('partial' => 'item', 'object' => array());
}}}
It should use given 'object' for $item, instead getting from controller's
$item!

2. Partial with empty() collection:
{{{
$Template->render(array('partial' => 'item', 'collection' => array()));
}}}
It should go to renderPartialCollection, instead renderPartial!

--
Ticket URL: <http://trac.akelos.org/ticket/267#comment:1>

Akelos PHP Framework

unread,
Dec 20, 2009, 7:39:04 AM12/20/09
to
#267: Nested Render Partial Collection: miss object within nested, and fail when
collection is empty
----------------------------------------------+-----------------------------
Reporter: firodj | Owner:
Type: patch | Status: closed
Priority: major | Milestone: 1.3.0
Component: Action Controller | Resolution: fixed
Keywords: nested render partial collection |
----------------------------------------------+-----------------------------
Changes (by bermi):

* status: new => closed
* resolution: => fixed
* milestone: 1.0.1 => 1.3.0

Comment:

Thanks for the pathc.

Added tests and fixed it on

http://github.com/bermi/akelos/commit/30708421c23175c9a378fbe70b7d8f661bd011eb

--
Ticket URL: <http://trac.akelos.org/ticket/267#comment:2>
Reply all
Reply to author
Forward
0 new messages