I'm Dan, and I don't care about your old code, I'm just here to update your console driver....Plan 9 style.

[Dan Cross]

[This is against a branch on /brho, but that's because it was in-flight before I created my own fork.]

The following changes since commit 5025b06858b52dcd0a536e76f7da6e6e74c59589:

  Add the Inferno license to files we got from Inferno (2015-10-28 12:05:12 -0400)

are available in the git repository at:

  g...@github.com:brho/akaros.git p9cons

for you to fetch changes up to ce0983817f0546e330a1bc073533e78d6f2d13c4:

  Replace the Inferno console driver with a less-crippled Plan 9 driver. (2015-10-29 14:15:54 -0400)

----------------------------------------------------------------

Dan Cross (4):

      Import the unmodified Plan 9 console driver.

      Run lindent on devcons.c

      Run spatch on devcons.c

      Replace the Inferno console driver with a less-crippled Plan 9 driver.

 kern/drivers/dev/cons.c | 1714 +++++++++++++++++++++++++++--------------------

 1 file changed, 974 insertions(+), 740 deletions(-)

[ron minnich]

Grabbed from the ucb gpl repo, right?

ron

--
You received this message because you are subscribed to the Google Groups "Akaros" group.
To unsubscribe from this group and stop receiving emails from it, send an email to akaros+un...@googlegroups.com.
To post to this group, send email to aka...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[ron minnich]

LGTM

Nice to have ^T back

ron

[Dan Cross]

Yes, that is correct.

[Barret Rhoden]

Hi -

On 2015-10-29 at 14:32 Dan Cross <cro...@gmail.com> wrote:
> [This is against a branch on /brho, but that's because it was
> in-flight before I created my own fork.]
>
> The following changes since commit
> 5025b06858b52dcd0a536e76f7da6e6e74c59589:
>
> Add the Inferno license to files we got from Inferno (2015-10-28
> 12:05:12 -0400)
>
> are available in the git repository at:
>
> g...@github.com:brho/akaros.git p9cons
>
> for you to fetch changes up to
> ce0983817f0546e330a1bc073533e78d6f2d13c4:
>
> Replace the Inferno console driver with a less-crippled Plan 9
> driver. (2015-10-29 14:15:54 -0400)
>
> ----------------------------------------------------------------
> Dan Cross (4):
> Import the unmodified Plan 9 console driver.
> Run lindent on devcons.c
> Run spatch on devcons.c
> Replace the Inferno console driver with a less-crippled Plan 9
> driver.

This is a little difficult to review, in that it's a wholesale
replacement. I think I spotted all of the changes, but might have
missed some.

The first three patches are fine: it's the usual, import, let
scripts/lindent do it's thing (which invariably screws things up, but
is better than nothing), then spatch. Checkpatch complains about all
three of these, but I can live with that.

The fourth patch is trickier, since it's a wholesale replacement of the
old with the new. The problem is that we might have some things that
are in the old that aren't in the new. For instance, this patch loses
#cons/urandom. More importantly, it also drops all of the VMM stuff
(#cons/V when your patch was made, and now called #cons/vmctl).

What else are we missing? There are 24 patches (on origin/staging)
from the time devcons was added until now. There's stuff like urandom,
renaming #c -> #cons, VMMs, etc. There might not be anything important
other than urandom and the VMM stuff. A lot of it is arbitrary stuff.

Also, since this is a new device, I'd like it if the struct dev is
explicit about its functions (as in e.g. k/d/d/eventfd.c).

In general, I wonder about some of the functionality here and the stuff
in the main k/s/console.c and k/a/x/console.c. Mucking with that isn't
a big deal at this point. In the future, we can consolidate a bit.

Barret

[Barret Rhoden]

On 2015-10-29 at 14:32 Dan Cross <cro...@gmail.com> wrote:

> [This is against a branch on /brho, but that's because it was
> in-flight before I created my own fork.]
>
> The following changes since commit
> 5025b06858b52dcd0a536e76f7da6e6e74c59589:
>
> Add the Inferno license to files we got from Inferno (2015-10-28
> 12:05:12 -0400)
>
> are available in the git repository at:
>
> g...@github.com:brho/akaros.git p9cons
>
> for you to fetch changes up to
> ce0983817f0546e330a1bc073533e78d6f2d13c4:
>
> Replace the Inferno console driver with a less-crippled Plan 9
> driver. (2015-10-29 14:15:54 -0400)

Thanks, merged to master at 2435991..df0c3f4 (from, to]

You can see the entire diff with 'git diff' or at
https://github.com/brho/akaros/compare/2435991...df0c3f4

Barret