Code Review - VM moving kthread bugfixes and timer interrupt thread.

[Gan Shun]

The following changes since commit 1165c2bda44b7f1fb3b776c0dc5b0fb4dd499961:

  Add networking unit tests (2015-11-03 12:00:38 -0500)

are available in the git repository at:

  g...@github.com:GanShun/akaros.git 1facde8a0e93ab20ace0be096fc37b53476d393b

for you to fetch changes up to 1facde8a0e93ab20ace0be096fc37b53476d393b:

  Modified vmx_launch in vmx.c to track the phy core of the vm every exit (2015-11-09 14:42:26 -0800)

----------------------------------------------------------------

GanShun (2):

      Added Timer thread. Started by consin thread.

      Modified vmx_launch in vmx.c to track the phy core of the vm every exit

 kern/arch/x86/vmm/intel/vmx.c |  3 +++

 kern/arch/x86/vmm/vmm.c       |  3 ++-

 tests/vmm/vmrunkernel.c       | 29 +++++++++++++++++++++++++++--

 3 files changed, 32 insertions(+), 3 deletions(-)

github link: 

https://github.com/ganshun/akaros/compare/1165c2bda44b7f1fb3b776c0dc5b0fb4dd499961...1facde8a0e93ab20ace0be096fc37b53476d393b

[Barret Rhoden]

Thanks, merged to master at 1ed63f9f8e25..70691bf40903 (from, to]

You can see the entire diff with 'git diff' or at
https://github.com/brho/akaros/compare/1ed63f9f8e25...70691bf40903


p.s.:

> are available in the git repository at:
>
> g...@github.com:GanShun/akaros.git
> 1facde8a0e93ab20ace0be096fc37b53476d393b

In the future, please also let me know the branch name. I had to guess
that this was still virtio-r.


> From e98845d757283e2c4bd724a9687adf32bea69469 Mon Sep 17 00:00:00 2001
> From: GanShun <gan...@gmail.com>
> Date: Tue, 3 Nov 2015 13:18:09 -0800
> Subject: Added Timer thread. Started by consin thread.

> + if (!timer_started && mcp) {
> + /* Start up timer thread */
> + if (pthread_create(&timerthread_struct, NULL, timer_thread, NULL)) {
> + fprintf(stderr, "pth_create failed for timer thread.");
> + perror("pth_create");

For future reference, you don't need the separate fprintf; you can just
put the whole message in perror.


> From 1facde8a0e93ab20ace0be096fc37b53476d393b Mon Sep 17 00:00:00 2001
> From: GanShun <gan...@gmail.com>
> Date: Wed, 4 Nov 2015 07:24:08 -0800
> Subject: Modified vmx_launch in vmx.c to track the phy core of the vm every
> exit

> --- a/kern/arch/x86/vmm/vmm.c
> +++ b/kern/arch/x86/vmm/vmm.c
> @@ -41,7 +41,8 @@ void vmm_init(void)
> printd("intel_vmm_init worked\n");
>
> //Register I_VMMCP_POSTED IRQ
> - register_irq(I_VMMCP_POSTED, vmmcp_posted_handler, NULL, MKBUS(BusLAPIC, 0, 0, 0));
> + //register_irq(I_VMMCP_POSTED, vmmcp_posted_handler, NULL,
> + // MKBUS(BusLAPIC, 0, 0, 0));

If you don't plan on using this IRQ handler, then you can remove it
completely (and also remove the function vmmcp_posted_handler()). No
need to do it now though.