aioodbc context managers

[iliev....@gmail.com]

Hello,

according to pyodbc documentation: 

https://github.com/mkleehammer/pyodbc/wiki/Connection

https://github.com/mkleehammer/pyodbc/wiki/Cursor

When using cursor/connection context manager, going out of scope have to

automatically commit the changes if autocommit is False.

The  _ContextManager.__aexit() invoke .close() but not commit() or rollback().

I think, the correct implementation should be:

async def __aexit__(self, exc_type, exc_value, traceback):

if exc_type:

await self.cursor.rollback()

elif not self.cursor.connection.autocommit:

await self.cursor.commit()

await self.cursor.close()

[Nickolai Novik]

Good point, aioodbc tries to have very similar API to pyodbc, so we should have similar context managers. Would you like to submit PR with mentioned change and test case?

--
You received this message because you are subscribed to the Google Groups "aio-libs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to aio-libs+u...@googlegroups.com.
To post to this group, send email to aio-...@googlegroups.com.
Visit this group at https://groups.google.com/group/aio-libs.
To view this discussion on the web visit https://groups.google.com/d/msgid/aio-libs/6320cd02-26e4-4ed0-9a86-a8ed99aad1bb%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[iliev....@gmail.com]

Sure, I would give a try.

[iliev....@gmail.com]

Hi Nikolay,

Thank you for merging the changes!

I would like to kindly ask you for a couple of more things. 

Please,  update the version of aioodbc and the Changes.txt. 

When download aioodbc I still see the old source code despite the changes being merge to master. 

We have a script that automatically download python libs, and as I am in the middle of a project it will be extremely useful

to have the updated library. I will be able to clean some of the code. 

Do you think this could be done in a short time?

If you need any help please let me know.

Kind regards,

Yulian ILiev

[Nickolai Novik]

Sure thing, I am planning to deploy new release this weekend.

--
You received this message because you are subscribed to the Google Groups "aio-libs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to aio-libs+u...@googlegroups.com.
To post to this group, send email to aio-...@googlegroups.com.
Visit this group at https://groups.google.com/group/aio-libs.

To view this discussion on the web visit https://groups.google.com/d/msgid/aio-libs/755abfd8-5cfb-4300-be1c-5879e8983402%40googlegroups.com.