Comment on revision r286 in aimc

[ai...@googlecode.com]

Comment by dickl...@google.com:

Score: Positive

General Comment:
Excellent. Now time for a round of IWYU (include what you use) fixups.
See note below.


Line-by-line comments:

File: /trunk/carfac/carfac.h (r286)
===============================================================================

Line 42: #include "carfac_output.h"
-------------------------------------------------------------------------------
You are missing some important includes in many of your files. Do not
count on transitive inclusion. See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Forward_Declarations#Forward_Declarations
"Always #include the file that actually provides the
declarations/definitions you need; do not rely on the symbol being brought
in transitively via headers not directly included. One exception is that
myfile.cc may rely on #includes and forward declarations from its
corresponding header file myfile.h."

For more information:
https://code.google.com/p/aimc/source/detail?r=286