Comment on revision r288 in aimc

[ai...@googlecode.com]

Comment by r...@google.com:

Line-by-line comments:

File: /trunk/carfac/carfac.cc (r288)
===============================================================================

Line 71: for (int32_t i = 0; i < n_segs; ++i) {
-------------------------------------------------------------------------------
Is there a good reason to break the input into segments instead of
processing it all at once? I.e. is RunSegment(sound_data, 0,
sound_data.size(), false, output) identical to Run(sound_data, output)?

Does keeping the segment size small decrease the size of some intermediate
arrays somewhere? If not, I'd just rewrite Run as a one liner, or (even
better, I think), get rid of it altogether to keep the API concise.

Thoughts? I'm happy to take care of this.

For more information:
https://code.google.com/p/aimc/source/detail?r=288

[Dick Lyon]

Yes; you want to be able to run this in a real-time system.  You don't have the input all at once.

--
You received this message because you are subscribed to the Google Groups "aimc-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to aimc-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Ron Weiss]

On Wed, May 29, 2013 at 11:51 AM, Dick Lyon <dick...@google.com> wrote:
> Yes; you want to be able to run this in a real-time system. You don't have
> the input all at once.

Understood. I'm suggesting that we do away with Run, not RunSegment,
which is clearly the more versatile interface.

>
>
>
>
> On Wed, May 29, 2013 at 8:27 AM, <ai...@googlecode.com> wrote:
>>
>> Comment by r...@google.com:
>>
>> Line-by-line comments:
>>
>> File: /trunk/carfac/carfac.cc (r288)
>>
>> ===============================================================================
>>
>> Line 71: for (int32_t i = 0; i < n_segs; ++i) {
>>
>> -------------------------------------------------------------------------------
>> Is there a good reason to break the input into segments instead of
>> processing it all at once? I.e. is RunSegment(sound_data, 0,
>> sound_data.size(), false, output) identical to Run(sound_data, output)?
>>
>> Does keeping the segment size small decrease the size of some intermediate
>> arrays somewhere? If not, I'd just rewrite Run as a one liner, or (even
>> better, I think), get rid of it altogether to keep the API concise.
>>
>> Thoughts? I'm happy to take care of this.
>>
>> For more information:
>> https://code.google.com/p/aimc/source/detail?r=288
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "aimc-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an

>> email to aimc-dev+u...@googlegroups.com.

>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>

> --
> You received this message because you are subscribed to the Google Groups
> "aimc-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to aimc-dev+u...@googlegroups.com.

[Dick Lyon]

Yes get rid of Run.