post-commit hook for Agilo does not send emails

[Mike]

We recently converted to Agilo from a regular Trac installation. The
post-commit hook for Trac included sending email to all parties
referenced in the ticket, but this appears to be missing in Agilo's
pre- and post-commit hooks. Am I missing something in the
configuration? If not, is this something that can be added?

Thanks,

Mike

[Felix Schwarz]

Yes, also the Agilo commit hook can send mails. Can you check that your
trac environment does send mails when you change a normal ticket?

fs

[Mike]

>  smime.p7s
> 4KViewDownload

Yes, I can confirm that our installation pre-agilo also sent the
emails when we changed tickets via the gui and also when we committed
via subversion.

Now our environment correctly sends emails when we change a normal
ticket; however it doesn't send an email when we check something in
through subversion. The hook is definitely being triggered because the
checkin information is posted to the ticket correctly.

Thanks again,

Mike

[Felix Schwarz]

Am 14.10.2009 22:56, schrieb Mike:
> Now our environment correctly sends emails when we change a normal
> ticket; however it doesn't send an email when we check something in
> through subversion. The hook is definitely being triggered because the
> checkin information is posted to the ticket correctly.

After reading your message, I'm not completely sure that I understood
your original request correctly. So just to clarify:
You would like to receive a message every time you close/change a ticket
by a subversion command (e.g. 'closes #735') which has the same format
as the trac ticket email which would be sent if you change the ticket
via the web interface, right?

If these mails are not being sent, this is strange because the agilo
commit hook uses the same infrastructure+configuration to send mails as
the web interface.

fs

[Mike]

>  smime.p7s
> 4KViewDownload

Yes, you've characterized it exactly, thanks.

I set up an entirely different system using the Agilo virtual
appliance just to verify that it's not something with our
configuration. After setting up notifications and adding the pre- and
post- commit scripts, the virtual appliance exhibits the same behavior
-- emails are not being sent during subversion commits, although the
subversion commits themselves are being added to the ticket correctly.
I do get emails if I make changes to a ticket through the GUI.

I looked into the original Trac post-commit script and it explicitly
sends these emails.

Thanks,

Mike

[Martin Häcker]

Hi there,

> I set up an entirely different system using the Agilo virtual
> appliance just to verify that it's not something with our
> configuration. After setting up notifications and adding the pre- and
> post- commit scripts, the virtual appliance exhibits the same behavior
> -- emails are not being sent during subversion commits, although the
> subversion commits themselves are being added to the ticket correctly.
> I do get emails if I make changes to a ticket through the GUI.
>
> I looked into the original Trac post-commit script and it explicitly
> sends these emails.

This is really strange, as we use this feature daily. Just to get more
context, are you running all of your trac environemnts inside the VM?
The VM you tried this with, was it the latest from agile42.com or an old
one you had downloaded earlier?

This could very well be a bug in the VM and the reason we haven't seen
this issue earlier.

Thanks in advance,
Martin

[Mike]

On Oct 19, 5:47 am, Martin Häcker <martin.haec...@agile42.com> wrote:
> Hi there,
>
> > I set up an entirely different system using the Agilo virtual
> > appliance just to verify that it's not something with our
> > configuration. After setting up notifications and adding the pre- and

> >post- commitscripts, the virtual appliance exhibits the same behavior

> > -- emails are not being sent during subversion commits, although the
> > subversion commits themselves are being added to the ticket correctly.
> > I do get emails if I make changes to a ticket through the GUI.
>

> > I looked into the original Tracpost-commitscript and it explicitly

> > sends these emails.
>
> This is really strange, as we use this feature daily. Just to get more
> context, are you running all of your trac environemnts inside the VM?
> The VM you tried this with, was it the latest from agile42.com or an old
> one you had downloaded earlier?
>
> This could very well be a bug in the VM and the reason we haven't seen
> this issue earlier.
>
> Thanks in advance,
> Martin

Hi Martin,

Sorry for the delay in getting back to you.

Our main installation is on a regular server -- not inside a VM. I
used the VM just to replicate the bug, to verify that it wasn't a
configuration problem on our main server. I experience this behavior
on both our main installation and a completely separate test
installation I set up inside the VM.

So you do get an email from the Agilo post-commit hook when you make a
subversion commit? We get emails for all changes to tickets EXCEPT for
changes that occur through the Agilo post-commit hook. Again, the
subversion commit message is added to the ticket correctly; the email
just isn't being sent.

I think I already said this, but this was not a problem when we used
the Trac post-commit hook. And looking at the code, the Trac post-
commit hook explicitly sends the email.

Thanks again,

Mike

[Martin Häcker]

Hi Mike,

> Sorry for the delay in getting back to you.

Likewise. :)

> Our main installation is on a regular server -- not inside a VM. I
> used the VM just to replicate the bug, to verify that it wasn't a
> configuration problem on our main server. I experience this behavior
> on both our main installation and a completely separate test
> installation I set up inside the VM.
>
> So you do get an email from the Agilo post-commit hook when you make a
> subversion commit? We get emails for all changes to tickets EXCEPT for
> changes that occur through the Agilo post-commit hook. Again, the
> subversion commit message is added to the ticket correctly; the email
> just isn't being sent.

Indeed, I was finally able to reproduce this behaviour in my local
installation, so I should now be able to go about fixing it. In the
meantime, here's the bug report to track it:
<https://dev.agile42.com/ticket/931>

> I think I already said this, but this was not a problem when we used
> the Trac post-commit hook. And looking at the code, the Trac post-
> commit hook explicitly sends the email.

Well, agilo uses it's own ticket model object which in theory should
abstract things like that.

It seems however that it does not do that yet. :/

Regards,
Martin

[Martin Häcker]

Hi Mike,

> Indeed, I was finally able to reproduce this behaviour in my local
> installation, so I should now be able to go about fixing it. In the
> meantime, here's the bug report to track it:
> <https://dev.agile42.com/ticket/931>

This will be fixed in the next release - in the meantime you should be
able to help yourself with the attached patch.

Please report back if it works.

Regards,
Martin

[Mike]

>  enable_ticket_notification.patch
> < 1KViewDownload

Yes, that works.

Thank you!