Question about navigation with language masters

[kyle giovannetti]

Hello,

I've been looking at this bug:
https://github.com/adobe/aem-core-wcm-components/issues/863

The TL;DR; on that is that if a navigation component on one site points to a section of a different site (site being /content/<site>) then the navigation doesn't exactly handle that properly as it assumes it can just translate those paths over to the current site.

The solution i was looking to implement would be

1) determine the language of the current page

2) if the navigation root points to a sibling language then use the current language

3) if the navigation root points to a completely different site, then try to use the correct language from that site. 

The only issue i have encountered with this solution is that one of the existing tests fails, specifically NavigationImplTest#testNavigationWithLanguageMaster().

In this test the:
currentPage: "/content/navigation-3-region/us/en/2"
navigationRoot: "/content/navigation-3-language-master/en"

Based on that content structure I would consider "navigation-3-region" and "navigation-3-language-master" to be completely different sites.

Unless there is some sort of live-copy setup configured, i don't see a relationship between the two.

Is this a really common layout? I can't find examples in Adobe's documentation of putting the language masters outside of the current site root and not having any sort of live relationship.

The above example is specifically relying on the bug, and the bug can't be fixed while maintaining that behaviour.

Any thoughts?

Kyle

[Vlad Băilescu]

Hi Kyle,

I agree that one does not normally expect language masters to be in a different site. So, instead of:

/content/navigation-3-region/us/en/2

/content/navigation-3-language-master/en

it should probably be:

/content/navigation-3/region/us/en/2 or even simpler: /content/navigation-3/us/en/2

/content/navigation-3/language-master/en

@Gabriel Walt , WDYT? Are there other scenarios to consider?

Vlad

--
You received this message because you are subscribed to the Google Groups "AEM Core Components Developer Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to aem-core-componen...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/aem-core-components-dev/421a8538-ac48-4720-8a9c-5efa76877550o%40googlegroups.com.