Pull Request Queue

[konrad....@netcentric.biz]

Hi everyone,

The list of open PRs is quite massive with 28 open, the oldest one from June. Although initial feedback is usually quite fast on the PRs, some haven't received any review up till now, although their build is green (e.g. https://github.com/adobe/aem-core-wcm-components/pull/1253 or https://github.com/adobe/aem-core-wcm-components/pull/1248). This is especially sad, as after those PRs have been raised, there were 2 releases and it is unclear what was the reason that those were not included.

If it is just a capacity issue then maybe you could nominate some other external (i.e. non Adobe) committers. Or is there a (non-public) roadmap which defines which features are supposed to end up in which release?

I can only talk for myself, but as implementor it is hard to push for contributions to the Core Components (instead of just implementing those in the custom proxy components) if PRs are not getting reviews in a timely manner...

Regards,

Konrad

[Vlad Băilescu]

Hi Konrad!

We are alarmed by the ever-increasing PR and issues queues too but we had a hard time addressing other high priority issues. We'll take some time next week to go through all the open PRs. We already took some time to label the PRs based on when we think we could merge them:

- Milestone 2.14.0 - next minor release, we'll try to finalise them next week

- Milestone 3.0.0 - next major release (they require a new version of a component), will follow up in the next message about this.

- Milestone Future - no plan yet

- Label move-to-contrib - planning to move these to https://github.com/adobe/aem-contrib-wcm-components because we don't think they're fit yet to be part of Core Components. That would act as an incubator where people could work and refine them.

Regarding external committers, we discussed that a few times. We welcome external committers to the contrib repo. For the Core Components themselves we're more reluctant to do that as our plan is to always include the latest version of Core Components in AEMaaCS and we're not sure we can manage the risk in an effective way. If we can set up a better e2e testing solution, we would very much like to add external comitters.

Best,

Vlad

--
You received this message because you are subscribed to the Google Groups "AEM Core Components Developer Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to aem-core-componen...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/aem-core-components-dev/2c2ab8e5-b8fb-4d88-9333-a2fc400357edn%40googlegroups.com.

[Konrad Windszus]

Hi Vlad,

thanks a lot. That clarifies things and indeed labelling the PRs helps contributors to understand what the current plan is.

I was not even aware of https://github.com/adobe/aem-contrib-wcm-components so probably that should be linked more prominently....

Cheers,

Konrad

To view this discussion on the web visit https://groups.google.com/d/msgid/aem-core-components-dev/CANG90TY2cjpmLaq43CFZ0CJ52GNOLZSxEc51%3Dwbo%3Dhu2-Rp4Nw%40mail.gmail.com.