NullPointerException in Java-Client-Library

[Alex]

If the httpRequest is not successfull then the client-library tries to throw a TokenResponseException in com.google.api.client.auth.oauth2.TokenRequest.executeUnparsed(). But during the construction of that exception a NullPointerException is thrown.

java.lang.NullPointerException

com.google.api.client.repackaged.com.google.common.base.Preconditions.checkNotNull(Preconditions.java:191)

com.google.api.client.util.Preconditions.checkNotNull(Preconditions.java:127)

com.google.api.client.json.jackson2.JacksonFactory.createJsonParser(JacksonFactory.java:96)

com.google.api.client.json.JsonObjectParser.parseAndClose(JsonObjectParser.java:85)

com.google.api.client.json.JsonObjectParser.parseAndClose(JsonObjectParser.java:81)

com.google.api.client.auth.oauth2.TokenResponseException.from(TokenResponseException.java:88)

com.google.api.client.auth.oauth2.TokenRequest.executeUnparsed(TokenRequest.java:287)

com.google.api.client.auth.oauth2.TokenRequest.execute(TokenRequest.java:307)

com.google.api.client.auth.oauth2.Credential.executeRefreshToken(Credential.java:570)

com.google.api.client.googleapis.auth.oauth2.GoogleCredential.executeRefreshToken(GoogleCredential.java:248)

com.google.api.client.auth.oauth2.Credential.refreshToken(Credential.java:489)

com.google.api.ads.common.lib.auth.OAuth2Helper.callRefreshToken(OAuth2Helper.java:70)

com.google.api.ads.common.lib.auth.OfflineCredentials.generateCredential(OfflineCredentials.java:144)

[Josh Radcliff (AdWords API Team)]

Hi,

Thanks for pointing this out. I believe this is the same issue highlighted on our github issues list:

https://github.com/googleads/googleads-java-lib/issues/19

We're working on a fix -- please subscribe to notifications on the github issue for updates.

Thanks,

Josh, AdWords API Team

[Stacie Waleyko]

Hi,

We saw the exact same error on July 17 when trying to get a new access token. Since we have never seen it before, and it happened on the 17th, I was wondering if it was possibly triggered by errors from this other thread: "Failed to refresh access token. { "error" : "invalid_client" } on perfectly good client"? Unfortunately we didn't log any of the HTTP request/responses so I do not have anymore information but the error did go away later in the day.

Thanks,

Stacie

[Josh Radcliff (AdWords API Team)]

Hi Stacie,

It's quite possible that the transient invalid_client errors were leading to the NPEs. I definitely would like to improve the error handling so we do not mask the underlying OAuth error with an NPE.

Cheers,

Josh, AdWords API TEam