%s%% not valid string format, why?

[Mark Carter]

I'm getting a lint error for this:

<string name="downloading_audio">正在下载音频 (已完成 %s%%)…</string>

I want to show something like:

正在下载音频 (已完成 42%)…

[Dallas Gutauckis]

See http://stackoverflow.com/questions/4414389/android-xml-percent-symbol/4417333#4417333

[Mark Carter]

Thanks - I tried the various answers but none of them made a difference unfortunately.

It looks like the Lint checker is confused into thinking %s%% is two parameters and then goes on to fail because the second parameter is not of the correct format.

Note - the format works perfectly well in String.format

Am I missing something?

[Tor Norbye]

Try switching to positional format;  %1$s%%

[Mark Carter]

Yep, I tried that (and also with and without the backslash suggestion) but still no luck...

[Mark Carter]

Something strange happening - if I remove the localized versions so that downloading_audio is only defined in values/strings.xml then I get a different error:

"Wrong argument count, format string downloading_audio requires 2 but format call supplies 1"

This happens irrespective if I use positional format or not.

[Tor Norbye]

Sounds like a weird bug. Would you mind sending the exact <string> item to reproduce the error (or a simplified version which still triggers both types of errors?).

-- Tor

[Mark Carter]

<string name="test">%s%%</string>

<string name="test">%1$s%%</string>

[Mark Carter]

To get the wrong argument count error:

<string name="test">%s%% c</string>

and have this code:

getString(R.string.test, "hello");

Same result for any string starting with those chars, e.g. <string name="test">%s%% cjkfhsdjfsdjkfh</string>

However, this:

<string name="test">%s%% </string> gives the same error I first reported:

"Format string 'test' is not a valid format string so it should not be passed to String.format"

[Tor Norbye]

Just to close out this thread; this is also tracked in issue

http://code.google.com/p/android/issues/detail?id=39758

and a fix is pending in https://android-review.googlesource.com/#/c/46741/

-- Tor

[Dallin Wilcox]

Looks like this issue is also affecting the other zero-argument conversion string, %n.  I submitted a bug for it:https://code.google.com/p/android/issues/detail?id=65692.

-Dallin

[Tor Norbye]

Thanks! Should be fixed for next version of the Gradle plugin and Studio.

-- Tor

--
You received this message because you are subscribed to the Google Groups "adt-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to adt-dev+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.