Memory leak in adns-python module, version 1.2.0 and earlier

[Michael V. Reztsov]

Memory leak has been found in function interpret_answer.
Patch:
===================================================
--- adnsmodule.c.orig 2006-12-31 20:25:29.000000000 +0300
+++ adnsmodule.c 2007-01-16 21:44:27.000000000 +0300
@@ -229,8 +229,9 @@
if (td) {
adns_rr_inthostaddr *v = \
answer->rrs.inthostaddr+i;
- a = Py_BuildValue("iO", v->i,
-
interpret_hostaddr(&v->ha));
+ o = interpret_hostaddr(&v->ha);
+ a = Py_BuildValue("iO", v->i, o);
+ Py_DECREF(o);
} else {
adns_rr_intstr *v =
answer->rrs.intstr+i;
a = Py_BuildValue("is", v->i, v->str);
===================================================

[Andy Dustman]

On Jan 17, 11:40 am, "Michael V. Reztsov" <xime...@gmail.com> wrote:
> Memoryleakhas been found in function interpret_answer.
> Patch:

There is an issue tracker for bugs and patches; please make use of it.
Your patch does look correct, however.

[Michael V. Reztsov]

> There is an issue tracker for bugs and patches; please make use of it.

Sorry, there was no time to report a issue.

> Your patch does look correct, however.

Thanks :-)