Re: [PATCH] D78111: tsan: fixes to ThreadClock::releaseStoreAcquire

[Dmitry Vyukov]

On Thu, Apr 16, 2020 at 11:08 PM Daniel Fava <danie...@gmail.com> wrote:
>
> Hi Dmitry,
>
> Thanks for the help. I’ve now committed the changes.
>
> I do have a question about workflow, maybe you could point me in the right direction.
>
> To get the patch in, I first cloned a fresh copy of the repo, applied the patch, committed and pushed. Is that a reasonable way of doing this?
>
> I had originally I tried merging the changes, but origin rejected my push.
>
> What do you usually do? Do you use rebase? (I’m not very familiar with rebase and didn’t want to risk breaking something.)
>
> Thanks again,
>
> Daniel

+sanitizer mailing lists

Hi Daniel,

Yes, I usually apply a patch, commit and push.
However, if it's mine change, I usually already have it committed,
then I rebase with git and then push.

I've also heard people mention some tool called Arcanist to work with
review changes:
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line
but I never used it personally.

> Begin forwarded message:
>
> From: Dmitry Vyukov via Phabricator <rev...@reviews.llvm.org>
> Subject: [PATCH] D78111: tsan: fixes to ThreadClock::releaseStoreAcquire
> Date: 16 April 2020 at 11:49:28 CEST
> To: danie...@gmail.com
> Reply-To: reviews+D78111+publ...@reviews.llvm.org
>
> dvyukov accepted this revision.
> dvyukov added a comment.
> This revision is now accepted and ready to land.
>
> You can now land this yourself, right?
>
>
> CHANGES SINCE LAST ACTION
> https://reviews.llvm.org/D78111/new/
>
> https://reviews.llvm.org/D78111
>
>
>
>