Re: Issue 4 in addendum: Notice: Undefined variable: class in doc_comment.php on line 86

5 views
Skip to first unread message

adde...@googlecode.com

unread,
Jan 9, 2011, 11:10:15 PM1/9/11
to addendum...@googlegroups.com

Comment #4 on issue 4 by shabbyrobe: Notice: Undefined variable: class in
doc_comment.php on line 86
http://code.google.com/p/addendum/issues/detail?id=4

Hello, I had trouble with this too when I was mucking benchmarking my app
with eAccelerator today. The change was quite small in the end - just
adding T_INTERFACE to the switch in DocComment. Here's a patch with tests.
All tests pass.

Attachments:
issue-4.diff 9.8 KB

adde...@googlecode.com

unread,
Jan 10, 2011, 3:38:07 AM1/10/11
to addendum...@googlegroups.com
Updates:
Status: Fixed

Comment #5 on issue 4 by jan.suchal: Notice: Undefined variable: class in

Thanks, applied.

BTW. Try creating patches with `svn diff -x --ignore-eol-style`. Leaves the
newline junk behind.

adde...@googlecode.com

unread,
Jan 10, 2011, 5:38:37 AM1/10/11
to addendum...@googlegroups.com

Comment #6 on issue 4 by shabbyrobe: Notice: Undefined variable: class in

Ahh, cheers for that. That's really good to know. Sorry for filling all
these patches up with silly newline changes. It does make them harder to
review.

Reply all
Reply to author
Forward
0 new messages