Issue 19 in addendum: Namespaces support

3 views
Skip to first unread message

codesite...@google.com

unread,
May 3, 2010, 9:52:38 AM5/3/10
to addendum...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 19 by NicolasJB.Lepage: Namespaces support
http://code.google.com/p/addendum/issues/detail?id=19

Hi,

I would like to know if you plan to add namespaces support.

It doesn't seem to need heavy modifications :
I just changed the regexp located at line 134 of annotation_parser.php to
accept backslashes.
Then I was able to use your framework with classes (and annotation classes)
located in namespaces.

Speaking of namespaces, don't you think it would find to move your classes
in an Addendum namespace ?? ;)

Thank you for your work !

--
You received this message because you are subscribed to the Google Groups "PHP Addendum library" group.
To post to this group, send email to addendum...@googlegroups.com.
To unsubscribe from this group, send email to addendum-discu...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/addendum-discuss?hl=en.

codesite...@google.com

unread,
May 3, 2010, 9:58:50 AM5/3/10
to addendum...@googlegroups.com

Comment #1 on issue 19 by jan.suchal: Namespaces support
http://code.google.com/p/addendum/issues/detail?id=19

Would you mind sending a patch with tests?

codesite...@google.com

unread,
May 3, 2010, 10:49:37 AM5/3/10
to addendum...@googlegroups.com

Comment #2 on issue 19 by NicolasJB.Lepage: Namespaces support
http://code.google.com/p/addendum/issues/detail?id=19

Here's the modified file, and one very very very succinct test.

I may make more tests later.

Attachments:
addendum.zip 3.8 KB
Reply all
Reply to author
Forward
0 new messages