Re: Issue 19 in addendum: Namespaces support

20 views
Skip to first unread message

adde...@googlecode.com

unread,
Jan 9, 2011, 9:29:03 AM1/9/11
to addendum...@googlegroups.com

Comment #3 on issue 19 by shabbyrobe: Namespaces support
http://code.google.com/p/addendum/issues/detail?id=19

I ended up needing this for a project I'm working on so I took Nicolas'
work, expanded on it and made a diff file. I fixed up DocComment to work
with namespaces as well and tested it in PHP 5.2. All tests pass.

Attachments:
issue-19.diff 5.6 KB

adde...@googlecode.com

unread,
Jan 9, 2011, 11:35:08 AM1/9/11
to addendum...@googlegroups.com
Updates:
Status: Fixed

Comment #4 on issue 19 by jan.suchal: Namespaces support
http://code.google.com/p/addendum/issues/detail?id=19

Thanks! I've removed newline changes from patch and applied it. Effective
as of #76 http://code.google.com/p/addendum/source/detail?r=76#

Please do verify that tests works. I don't have 5.2 installed.

adde...@googlecode.com

unread,
Jan 9, 2011, 11:41:10 AM1/9/11
to addendum...@googlegroups.com

Comment #5 on issue 19 by shabbyrobe: Namespaces support
http://code.google.com/p/addendum/issues/detail?id=19

Oh, dang, sorry about the newline changes - I thought I had filtered them
out. I did run all of the tests on 5.2.11 on Windows. It was the only copy
of 5.2.11 I had handy. I will throw up an ubuntu VM tomorrow if I get time
and try 5.2 on there as well.

adde...@googlecode.com

unread,
Jan 9, 2011, 11:45:18 AM1/9/11
to addendum...@googlegroups.com

Comment #6 on issue 19 by shabbyrobe: Namespaces support
http://code.google.com/p/addendum/issues/detail?id=19

Forgot to mention in my previous message that all the tests passed when I
ran em on 5.2/Win. Except of course the namespace one ;)

adde...@googlecode.com

unread,
Jan 9, 2011, 11:49:26 AM1/9/11
to addendum...@googlegroups.com
Updates:
Status: Verified

Comment #7 on issue 19 by jan.suchal: Namespaces support
http://code.google.com/p/addendum/issues/detail?id=19

Thanks.

Reply all
Reply to author
Forward
0 new messages