"Don't run on pages on this domain" doesn't work

1,029 views
Skip to first unread message

Stupid Chrome User

unread,
Nov 6, 2011, 8:44:03 AM11/6/11
to adblockforchrome-discuss
I do it but Adblock still insert style sheet stuff into the HTML. Why?

I still get <style type="text/css" style="display: none !important; ">/
*This block of style rules is inserted by AdBlock*/ and a whole bunch
of CSS selectors.

Also, if ABP for Chrome is meant to stop ads before they hit the page
then why is it modifying the CSS?

Thanks for clarifying these issues for me ...

Michael Gundlach

unread,
Nov 8, 2011, 1:20:37 PM11/8/11
to adblockforch...@googlegroups.com
On Sun, Nov 6, 2011 at 8:44 AM, Stupid Chrome User <anthony...@gmail.com> wrote:
I do it but Adblock still insert style sheet stuff into the HTML. Why?

Be sure to reload the page after doing so.  When I e.g. go to sorryrobot.com, then click toolbar menu -> Don't run on pages on this domain -> OK, and then reload the page, I see no <style> element.
 

I still get <style type="text/css" style="display: none !important; ">/
*This block of style rules is inserted by AdBlock*/ and a whole bunch
of CSS selectors.

Also, if ABP for Chrome is meant to stop ads before they hit the page
then why is it modifying the CSS?

1. This is AdBlock, not Adblock Plus for Google Chrome, which is a separate project (adblockplus.org).
2. Some ads can be blocked ahead of time, but some get put straight into the HTML of the page, so the only option is to hide them afte rthe fact.
 
Thanks for clarifying these issues for me ...

Sure, hope this helps!
Michael 

Stupid Chrome User

unread,
Nov 8, 2011, 2:08:06 PM11/8/11
to adblockforchrome-discuss
Hi Michael,

Of course I meant AB, not ABP :)

Oh! I discovered that because I have a dev site and I'm using ports
like :3301 and :8080 when I tell Adblock to ignore this site the
pattern is not matched. If I go into the configuration and manually
add the port then the <style> tag does not show up. This is probably
ok for most users as they will be doing this for regular sites on port
80. It would be nice if you took the port into consideration though
maybe? I don't know. Up to you. Or you could give the user the option
to block on all ports or whatever. My mistake, it's a corner case.

Regarding the amount of styles inserted into the page, I see that this
is necessary but it seems like overkill. On my install it is 74k. I
know that you cache this so you're not pulling down 74k each time but
Chrome has to parse the 74k for each page. It seems very heavy, is
there nothing that can be done?

Thanks for the great blocking tool,
Anthony

On Nov 8, 8:20 pm, Michael Gundlach <adblockforchr...@gmail.com>
wrote:
> On Sun, Nov 6, 2011 at 8:44 AM, Stupid Chrome User <anthony.dur...@gmail.com

Michael Gundlach

unread,
Nov 8, 2011, 4:14:18 PM11/8/11
to adblockforch...@googlegroups.com
Hi Anthony,

Glad you figured it out.  No, the <style> tag basically has to exist as it does.  We could maybe make it a <link> tag but that would involve a separate fetch, so I can't imagine it would be faster.

Michael
Reply all
Reply to author
Forward
0 new messages