Review please

Michael Gundlach

unread,

Dec 12, 2012, 11:40:25 AM12/12/12

to Dev List

Could someone please review Issue 7288, verifying that when you load the code AdBlock works as normal? This needs to ship urgently in prep for launching an app in the Chrome Web Store, so that users who search for "adblock" find AdBlock.

Thanks!

Michael

Famlam

unread,

Dec 12, 2012, 12:04:59 PM12/12/12

to adblockfor...@googlegroups.com

I won't give you my review, but just a note: I doubt it is legal to share any kind of information with external apps, without asking the users permission. (Just like a website may for example not store cookies of Google Analytics without showing a warning (whole EU I thought) or asking explicitly for the users permission (few countries, including NL)).

Michael Gundlach

unread,

Dec 12, 2012, 12:41:58 PM12/12/12

to Dev List

Thanks for your opinion!

Michael Gundlach

unread,

Dec 12, 2012, 1:02:14 PM12/12/12

to Dev List

I'm shipping this branch now, but please feel free to review for bugs/problems.

fam lam

unread,

Dec 12, 2012, 1:41:11 PM12/12/12

to AdBlock dev group

?? I didn't give an opinion, did I?

From: adblockf...@gmail.com
Date: Wed, 12 Dec 2012 12:41:58 -0500
Subject: Re: Review please
To: adblockfor...@googlegroups.com

Reply all

Reply to author

Forward