something broke AS + cancan on 3.2.9

Hernan Astudillo

unread,

May 22, 2012, 1:49:39 AM5/22/12

to activescaffold

only happens on AS controllers. Problem dissappear by commenting cancan out of Gemfile. Works fine with cancan on controllers without AS.
If i switch AS to 3.2.7 problem goes away.

Started GET "/productos" for 127.0.0.1 at 2012-05-22 01:16:34 -0400
Processing by ProductosController#index as HTML
User Load (1.0ms) SELECT "users".* FROM "users" WHERE "users"."id" = 1 LIMIT 1
Completed 500 Internal Server Error in 54ms

SystemStackError (stack level too deep):
actionpack (3.2.3) lib/action_dispatch/middleware/reloader.rb:70

Rendered /home/nano/.rvm/gems/ruby-1.9.3-p194@pukara/gems/actionpack-3.2.3/lib/action_dispatch/middleware/templates/rescues/_trace.erb (1.4ms)
Rendered /home/nano/.rvm/gems/ruby-1.9.3-p194@pukara/gems/actionpack-3.2.3/lib/action_dispatch/middleware/templates/rescues/_request_and_response.erb (1.3ms)
Rendered /home/nano/.rvm/gems/ruby-1.9.3-p194@pukara/gems/actionpack-3.2.3/lib/action_dispatch/middleware/templates/rescues/diagnostics.erb within rescues/layout (10.3ms)
^C[2012-05-22 01:18:21] INFO going to shutdown ...
[2012-05-22 01:18:21] INFO WEBrick::HTTPServer#start done.

ser...@entrecables.com

unread,

May 22, 2012, 3:05:51 PM5/22/12

to actives...@googlegroups.com

I can't see any line of active_scaffold, if you don't want to send full
backtrace because is very long, unless I will need some lines of the
backtrace displaying active_scaffold

On Tue, 22 May 2012 01:49:39 -0400, Hernan Astudillo <naa...@gmail.com>
wrote:

> --
> You received this message because you are subscribed to the Google
> Groups "ActiveScaffold : Ruby on Rails plugin" group.
> To post to this group, send email to actives...@googlegroups.com.
> To unsubscribe from this group, send email to
> activescaffol...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/activescaffold?hl=en.

Hernan Astudillo

unread,

May 24, 2012, 12:58:38 PM5/24/12

to actives...@googlegroups.com

That's all the output i can get! :(
Today i updated another app to latest AS (3.2.11) and also got broken.
Removed backtrace silencers which didn't have any effect. The call(env) in reload middleware is crashing. I think that's why it's not logging.

I found that what's broken is something specifically introduced in AS 3.2.9, since with 3.2.8 it goes away. I'll keep digging.

this is all the log i can make it output:

$ rails s
=> Booting Thin
=> Rails 3.2.3 application starting in development on http://0.0.0.0:3000
=> Call with -d to detach
=> Ctrl-C to shutdown server
>> Thin web server (v1.3.1 codename Triple Espresso)
>> Maximum connections set to 1024
>> Listening on 0.0.0.0:3000, CTRL+C to stop

Started GET "/usuarios" for 127.0.0.1 at 2012-05-24 12:45:55 -0400
Processing by UsuariosController#index as HTML
Usuario Load (0.7ms) SELECT "usuarios".* FROM "usuarios" WHERE "usuarios"."login" = 'sector2' LIMIT 1
CACHE (0.0ms) SELECT "usuarios".* FROM "usuarios" WHERE "usuarios"."login" = 'sector2' LIMIT 1
Rol Load (0.6ms) SELECT "roles".* FROM "roles" INNER JOIN "roles_usuarios" ON "roles"."id" = "roles_usuarios"."rol_id" WHERE "roles_usuarios"."usuario_id" = 5
Accion Load (0.6ms) SELECT "acciones".* FROM "acciones"
Estado Load (0.5ms) SELECT "estados".* FROM "estados" WHERE "estados"."id" IN (1, 2)
Completed 500 Internal Server Error in 139ms

SystemStackError (stack level too deep):
actionpack (3.2.3) lib/action_dispatch/middleware/reloader.rb:70

Rendered /home/nano/.rvm/gems/ruby-1.9.3-p194@sabores/gems/actionpack-3.2.3/lib/action_dispatch/middleware/templates/rescues/_trace.erb (0.7ms)
Rendered /home/nano/.rvm/gems/ruby-1.9.3-p194@sabores/gems/actionpack-3.2.3/lib/action_dispatch/middleware/templates/rescues/_request_and_response.erb (0.6ms)
Rendered /home/nano/.rvm/gems/ruby-1.9.3-p194@sabores/gems/actionpack-3.2.3/lib/action_dispatch/middleware/templates/rescues/diagnostics.erb within rescues/layout (5.6ms)
^C>> Stopping ...
Exiting

Hernan Astudillo

unread,

May 24, 2012, 1:21:02 PM5/24/12

to actives...@googlegroups.com

This is the breaking commit

https://github.com/activescaffold/active_scaffold/commit/694e344538c68d2091fcfa71d153d5c1ff603eb4

my guess is some of this changes:

here:

lib/active_scaffold/active_record_permissions.rb
44+ base.send :include, ActiveRecordPermissions::Permissions

and/or here:

lib/active_scaffold_env.rb:

11

-ActiveRecord::Base.class_eval     {include ActiveRecordPermissions::Permissions}

It could be something else, but it's definitely in that commit.

cheers,

ser...@entrecables.com

unread,

May 24, 2012, 3:40:49 PM5/24/12

to actives...@googlegroups.com

It's not a very important change, I could revert that.
Can you try to use cancan_fixes branch? I have reverted that change
(only those lines) so you can try it

Thanks for looking for the change which broke it

On Thu, 24 May 2012 13:21:02 -0400, Hernan Astudillo <naa...@gmail.com>
wrote:

> This is the breaking commit
>
> https://github.com/activescaffold/active_scaffold/commit/694e344538c68d2091fcfa71d153d5c1ff603eb4

> [1]

>
> my guess is some of this changes:
>
> here:
>
> lib/active_scaffold/active_record_permissions.rb
> 44+ base.send :include, ActiveRecordPermissions::Permissions
>
> and/or here:
>
> lib/active_scaffold_env.rb:
>
> 11
>
>
> -ActiveRecord::Base.class_eval {include ActiveRecordPermissions::Permissions}
>
> It could be something else, but it's definitely in that commit.
>
> cheers,
>

> On Thu, May 24, 2012 at 12:58 PM, Hernan Astudillo wrote:
> That's all the output i can get! :(
> Today i updated another app to latest AS (3.2.11) and also got broken.
>
> Removed backtrace silencers which didn't have any effect. The
> call(env) in reload middleware is crashing. I think that's why it's
> not logging.
>
> I found that what's broken is something specifically introduced in AS
> 3.2.9, since with 3.2.8 it goes away. I'll keep digging.
>
> this is all the log i can make it output:
>
> $ rails s
> => Booting Thin
> => Rails 3.2.3 application starting in development on

> http://0.0.0.0:3000 [3]

> => Call with -d to detach
> => Ctrl-C to shutdown server
>>> Thin web server (v1.3.1 codename Triple Espresso)
> >> Maximum connections set to 1024

>>> Listening on 0.0.0.0:3000 [4], CTRL+C to stop

> actives...@googlegroups.com [7].

> > To unsubscribe from this group, send email to

> > activescaffol...@googlegroups.com [8].

> > For more options, visit this group at

> > http://groups.google.com/group/activescaffold?hl=en [9].

>
> --
> You received this message because you are subscribed to the Google
> Groups "ActiveScaffold : Ruby on Rails plugin" group.
> To post to this group, send email to actives...@googlegroups.com

> [10].

> To unsubscribe from this group, send email to

> activescaffol...@googlegroups.com [11].

> For more options, visit this group at

> http://groups.google.com/group/activescaffold?hl=en [12].

>
> --
> You received this message because you are subscribed to the Google
> Groups "ActiveScaffold : Ruby on Rails plugin" group.
> To post to this group, send email to actives...@googlegroups.com.
> To unsubscribe from this group, send email to
> activescaffol...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/activescaffold?hl=en.
>
>

> Links:
> ------
> [1]
> https://github.com/activescaffold/active_scaffold/commit/694e344538c68d2091fcfa71d153d5c1ff603eb4
> [2] mailto:naa...@gmail.com
> [3] http://0.0.0.0:3000
> [4] http://0.0.0.0:3000
> [5] mailto:ser...@entrecables.com
> [6] mailto:naa...@gmail.com
> [7] mailto:actives...@googlegroups.com
> [8] mailto:activescaffold%2Bunsu...@googlegroups.com
> [9] http://groups.google.com/group/activescaffold?hl=en
> [10] mailto:actives...@googlegroups.com
> [11] mailto:activescaffold%2Bunsu...@googlegroups.com
> [12] http://groups.google.com/group/activescaffold?hl=en

Hernan Astudillo

unread,

May 24, 2012, 6:56:23 PM5/24/12

to actives...@googlegroups.com

nope... wasn't that.
I replayed the commit locally file by file and finally found the nasty code:

at

lib/active_scaffold/actions/nested.rb

89

-        active_scaffold_config.model

89

+        super

https://github.com/activescaffold/active_scaffold/blob/694e344538c68d2091fcfa71d153d5c1ff603eb4/lib/active_scaffold/actions/nested.rb

I even go forward with that file stuck at that commit (43fdf60 Merge branch 'master' of github.com:activescaffold/active_scaffold , the one before the crash) and everything goes fine.

What i don't know is why "super" is going on a recursive loop with cancan?

thanks,

ser...@entrecables.com

unread,

May 24, 2012, 8:33:30 PM5/24/12

to actives...@googlegroups.com

I thought it could be the problem but I didn't understand why. I can't
reproduce it with some test Modules, like this:

module Core
def boc
puts 'core'
self.class
end
end

module Cancan
def self.included(base)
base.alias_method_chain :boc, :cancan
end
def boc_with_cancan
puts 'cancan'
boc_without_cancan
end
end

module Nested
def boc
puts 'nested'
super
end
end

Core.send :include, Cancan

class A
include Core
def boc
super
end
end

A.new.boc
cancan
core
=> A

A.send :include, Nested
A.new.boc
nested
cancan
core
=> A

Anyway, alias_method_chain should not be needed here, I have changed
with super, you can use cancan_fixes branch and let me know if it works.

On Thu, 24 May 2012 18:56:23 -0400, Hernan Astudillo <naa...@gmail.com>
wrote:

> nope... wasn't that.
> I replayed the commit locally file by file and finally found the nasty
> code:
>
> at
>
> lib/active_scaffold/actions/nested.rb
> 89
>
> - active_scaffold_config.model
> 89
>
> + super
>
> https://github.com/activescaffold/active_scaffold/blob/694e344538c68d2091fcfa71d153d5c1ff603eb4/lib/active_scaffold/actions/nested.rb

> [1]

>
> I even go forward with that file stuck at that commit (43fdf60 Merge
> branch 'master' of github.com:activescaffold/active_scaffold , the one
> before the crash) and everything goes fine.
>
> What i don't know is why "super" is going on a recursive loop with
> cancan?
>
> thanks,
>

> On Thu, May 24, 2012 at 3:40 PM, wrote:
> It's not a very important change, I could revert that.
> Can you try to use cancan_fixes branch? I have reverted that change
> (only those lines) so you can try it
>
> Thanks for looking for the change which broke it
>
> On Thu, 24 May 2012 13:21:02 -0400, Hernan Astudillo

> wrote:
>
>> This is the breaking commit
> >
> >
> https://github.com/activescaffold/active_scaffold/commit/694e344538c68d2091fcfa71d153d5c1ff603eb4

> [4]

> > http://0.0.0.0:3000 [5] [3]

>
>> => Call with -d to detach
> > => Ctrl-C to shutdown server
> >>> Thin web server (v1.3.1 codename Triple Espresso)
> > >> Maximum connections set to 1024

> >>> Listening on 0.0.0.0:3000 [6] [4], CTRL+C to stop

> > actives...@googlegroups.com [7] [7].

>
>> > To unsubscribe from this group, send email to

> > > activescaffol...@googlegroups.com [8] [8].

>
>> > For more options, visit this group at

> > > http://groups.google.com/group/activescaffold?hl=en [9] [9].

>
>>
> > --
> > You received this message because you are subscribed to the
> Google
> > Groups "ActiveScaffold : Ruby on Rails plugin" group.
> > To post to this group, send email to
> actives...@googlegroups.com [10]
> > [10].
>
>> To unsubscribe from this group, send email to

> > activescaffol...@googlegroups.com [11] [11].

>
>> For more options, visit this group at

> > http://groups.google.com/group/activescaffold?hl=en [12] [12].

>
>>
> > --
> > You received this message because you are subscribed to the
> Google
> > Groups "ActiveScaffold : Ruby on Rails plugin" group.
> > To post to this group, send email to

> actives...@googlegroups.com [13].

> > To unsubscribe from this group, send email to

> > activescaffol...@googlegroups.com [14].

> > For more options, visit this group at

> > http://groups.google.com/group/activescaffold?hl=en [15].

> >
> >
> > Links:
> > ------
> > [1]
> >
> https://github.com/activescaffold/active_scaffold/commit/694e344538c68d2091fcfa71d153d5c1ff603eb4

> [16]
> > [2] mailto:naa...@gmail.com [17]
> > [3] http://0.0.0.0:3000 [18]
> > [4] http://0.0.0.0:3000 [19]
> > [5] mailto:ser...@entrecables.com [20]
> > [6] mailto:naa...@gmail.com [21]
> > [7] mailto:actives...@googlegroups.com [22]
> > [8] mailto:activescaffold%2Bunsu...@googlegroups.com [23]
> > [9] http://groups.google.com/group/activescaffold?hl=en [24]
> > [10] mailto:actives...@googlegroups.com [25]
> > [11] mailto:activescaffold%2Bunsu...@googlegroups.com [26]
> > [12] http://groups.google.com/group/activescaffold?hl=en [27]

>
> --
> You received this message because you are subscribed to the Google
> Groups "ActiveScaffold : Ruby on Rails plugin" group.
> To post to this group, send email to actives...@googlegroups.com

> [28].

> To unsubscribe from this group, send email to

> activescaffol...@googlegroups.com [29].

> For more options, visit this group at

> http://groups.google.com/group/activescaffold?hl=en [30].

>
> --
> You received this message because you are subscribed to the Google
> Groups "ActiveScaffold : Ruby on Rails plugin" group.
> To post to this group, send email to actives...@googlegroups.com.
> To unsubscribe from this group, send email to
> activescaffol...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/activescaffold?hl=en.
>
>
> Links:
> ------
> [1]

> https://github.com/activescaffold/active_scaffold/blob/694e344538c68d2091fcfa71d153d5c1ff603eb4/lib/active_scaffold/actions/nested.rb
> [2] mailto:ser...@entrecables.com
> [3] mailto:naa...@gmail.com
> [4]
> https://github.com/activescaffold/active_scaffold/commit/694e344538c68d2091fcfa71d153d5c1ff603eb4
> [5] http://0.0.0.0:3000
> [6] http://0.0.0.0:3000

> [7] mailto:actives...@googlegroups.com
> [8] mailto:activescaffold%2Bunsu...@googlegroups.com
> [9] http://groups.google.com/group/activescaffold?hl=en
> [10] mailto:actives...@googlegroups.com
> [11] mailto:activescaffold%2Bunsu...@googlegroups.com
> [12] http://groups.google.com/group/activescaffold?hl=en

Hernan Astudillo

unread,

May 24, 2012, 9:36:43 PM5/24/12

to actives...@googlegroups.com

according to this answer, alias_method_chain is no longer used in RoR3, there's a better/cleaner way:
http://stackoverflow.com/questions/3689736/rails-3-alias-method-chain-still-used

Your branch "cancan_fix" works like a charm by the way.

thanks a lot.

BTW: i was trying to branch, fix and pull request myself but i'm originally forked from vhochstein when he changed to RoR3, and can't <pull request> to you. Do you know any other way besides destroying my fork and forking again?

ser...@entrecables.com

unread,

May 24, 2012, 9:55:37 PM5/24/12

to actives...@googlegroups.com

Fixed in master. alias_method_chain is only needed if you want to
override a method defined in a class including a module. For example, if
you want to override a method defined in ActiveRecord::Base (not defined
in a module included in ActiveRecord::Base) you have to use
alias_method_chain (or two alias_method calls)

I don't think there is a way to change repository you have forked from.

On Thu, 24 May 2012 21:36:43 -0400, Hernan Astudillo <naa...@gmail.com>
wrote:

> according to this answer, alias_method_chain is no longer used in
> RoR3, there's a better/cleaner way:
> http://stackoverflow.com/questions/3689736/rails-3-alias-method-chain-still-used

> [1]

>
> Your branch "cancan_fix" works like a charm by the way.
>
> thanks a lot.
>
> BTW: i was trying to branch, fix and pull request myself but i'm
> originally forked from vhochstein when he changed to RoR3, and can't

> to you. Do you know any other way besides destroying my fork and
> forking again?
>

> wrote:
>
>> nope... wasn't that.
> > I replayed the commit locally file by file and finally found the
> nasty
> > code:
> >
> > at
> >
> > lib/active_scaffold/actions/nested.rb
> > 89
> >
> > -        active_scaffold_config.model
> >    89
> >
> > +        super
> >
> >
> https://github.com/activescaffold/active_scaffold/blob/694e344538c68d2091fcfa71d153d5c1ff603eb4/lib/active_scaffold/actions/nested.rb

> [4]

> > [1]
>
>>
> > I even go forward with that file stuck at that commit (43fdf60
> Merge
> > branch 'master' of github.com:activescaffold/active_scaffold , the
> one
> > before the crash) and everything goes fine.
> >
> > What i don't know is why "super" is going on a recursive loop with
> > cancan?
> >
> > thanks,
> >
>
>> On Thu, May 24, 2012 at 3:40 PM, wrote:
> > It's not a very important change, I could revert that.
> > Can you try to use cancan_fixes branch? I have reverted that
> change
> > (only those lines) so you can try it
> >
> > Thanks for looking for the change which broke it
> >
> > On Thu, 24 May 2012 13:21:02 -0400, Hernan Astudillo
>
>> wrote:
> >
> >> This is the breaking commit
> > >
> > >
> >
> https://github.com/activescaffold/active_scaffold/commit/694e344538c68d2091fcfa71d153d5c1ff603eb4

> [5]

> > > http://0.0.0.0:3000 [6] [5] [3]

>
>>
> >> => Call with -d to detach
> > > => Ctrl-C to shutdown server
> > >>> Thin web server (v1.3.1 codename Triple Espresso)
> > > >> Maximum connections set to 1024

> > >>> Listening on 0.0.0.0:3000 [7] [6] [4], CTRL+C to stop

> > > actives...@googlegroups.com [8] [7] [7].

>
>>
> >> > To unsubscribe from this group, send email to

> > > > activescaffol...@googlegroups.com [9] [8] [8].

>
>>
> >> > For more options, visit this group at

> > > > http://groups.google.com/group/activescaffold?hl=en [10]

> [9] [9].
>
>>
> >>
> > > --
> > > You received this message because you are subscribed to the
> > Google
> > > Groups "ActiveScaffold : Ruby on Rails plugin" group.
> > > To post to this group, send email to

> > actives...@googlegroups.com [11] [10]

> > > [10].
> >
> >> To unsubscribe from this group, send email to

> > > activescaffol...@googlegroups.com [12] [11] [11].

>
>>
> >> For more options, visit this group at

> > > http://groups.google.com/group/activescaffold?hl=en [13] [12]

> [12].
>
>>
> >>
> > > --
> > > You received this message because you are subscribed to the
> > Google
> > > Groups "ActiveScaffold : Ruby on Rails plugin" group.
> > > To post to this group, send email to

> > actives...@googlegroups.com [14] [13].

>
>> > To unsubscribe from this group, send email to

> > > activescaffol...@googlegroups.com [15] [14].

>
>> > For more options, visit this group at

> > > http://groups.google.com/group/activescaffold?hl=en [16] [15].

>
>> >
> > >
> > > Links:
> > > ------
> > > [1]
> > >
> >
> https://github.com/activescaffold/active_scaffold/commit/694e344538c68d2091fcfa71d153d5c1ff603eb4

> [17]
> > [16]
> > > [2] mailto:naa...@gmail.com [18] [17]
> > > [3] http://0.0.0.0:3000 [19] [18]
> > > [4] http://0.0.0.0:3000 [20] [19]
> > > [5] mailto:ser...@entrecables.com [21] [20]
> > > [6] mailto:naa...@gmail.com [22] [21]
> > > [7] mailto:actives...@googlegroups.com [23] [22]
> > > [8] mailto:activescaffold%2Bunsu...@googlegroups.com [24]
> [23]
> > > [9] http://groups.google.com/group/activescaffold?hl=en [25]
> [24]
> > > [10] mailto:actives...@googlegroups.com [26] [25]
> > > [11] mailto:activescaffold%2Bunsu...@googlegroups.com [27]
> [26]
> > > [12] http://groups.google.com/group/activescaffold?hl=en [28]

> [27]
>
>>
> > --
> > You received this message because you are subscribed to the
> Google
> > Groups "ActiveScaffold : Ruby on Rails plugin" group.
> > To post to this group, send email to

> actives...@googlegroups.com [29]

> > [28].
>
>> To unsubscribe from this group, send email to

> > activescaffol...@googlegroups.com [30] [29].

>
>> For more options, visit this group at

> > http://groups.google.com/group/activescaffold?hl=en [31] [30].

>
>>
> > --
> > You received this message because you are subscribed to the
> Google
> > Groups "ActiveScaffold : Ruby on Rails plugin" group.
> > To post to this group, send email to

> actives...@googlegroups.com [32].

> > To unsubscribe from this group, send email to

> > activescaffol...@googlegroups.com [33].

> > For more options, visit this group at

>
> --
> You received this message because you are subscribed to the Google
> Groups "ActiveScaffold : Ruby on Rails plugin" group.
> To post to this group, send email to actives...@googlegroups.com

> [65].

> To unsubscribe from this group, send email to

> activescaffol...@googlegroups.com [66].

> For more options, visit this group at

> http://groups.google.com/group/activescaffold?hl=en [67].

>
> --
> You received this message because you are subscribed to the Google
> Groups "ActiveScaffold : Ruby on Rails plugin" group.
> To post to this group, send email to actives...@googlegroups.com.
> To unsubscribe from this group, send email to
> activescaffol...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/activescaffold?hl=en.
>
>
> Links:
> ------
> [1]

> http://stackoverflow.com/questions/3689736/rails-3-alias-method-chain-still-used

> [2] mailto:ser...@entrecables.com
> [3] mailto:naa...@gmail.com
> [4]

Reply all

Reply to author

Forward