setTheme not working for android < 2.3

[Esben Gaarsmand]

getSupportActionbar

In my manifest I use following theme:

<activity

            android:name="x.x.MainActivity"

            android:screenOrientation="portrait"

            android:theme="@style/Theme.Sherlock.NoActionBar">

In my onCreate I have following:

        setTheme(R.style.Theme_Sherlock);

        this.getSupportActionBar().setTitle(R.string.title_activity_main);// <-- this will crash on android 2.3 and below, will work fine on ice cream sandwich, the supportactionbar is null as the theme haven't been updated.

        

        // Start regular onCreate()

        super.onCreate(savedInstanceState);

        setContentView(R.layout.activity_main);

This would be nice if it worked because it would be possible to be free of the pre action bar before the activity is started.

[SimonVT]

Not likely this can, or will, be fixed, doing stuff before super.onCreate() is not advised, and there are certain limitations (especially on older platforms).

[Jake Wharton]

You are setting the theme on the manifest and then using setTheme to change it?!? You should set the theme in the manifest and that's it.

---
Jake Wharton
http://about.me/jakewharton

[kenny goers]

Is that the case? I've been using setTheme on activities since 1.6 without an issue, I offer my users a light and dark option for theming and this is by far the easiest way and the only way setTheme really works is if called before the super.onCreate method, the only other thing I'd do before a call to the super class is setting the transition animation.

Is the setTheme call being depreciated? I hadn't read that.

That said, if there is an easier way I'd love to hear it.

Kenny.

[Jake Wharton]

It's not deprecated and yes you should call it before super.onCreate if you are providing theme-switching functionality only. Otherwise you should always declare it in the manifest.