--count should not display the file name for a single file - Issue# 74

[Raj A. Singh]

Folks,

I have made some changes to Ack.pm file to meet the requirement descibed for issue# 74. What is the next step? I guess, i need to send the diff of changed code. Please let me know.

Although, ack works as expected for --count and --no-filename flags but few tests fail when i run 'make test'. Any pointers in resolving this will help. This is where it starts failing -

t/longopts................ok
t/module..................
#   Failed test at t/module.t line 257.
#     Structures begin differing at:
#          $got->[0][0] = 'count0'
#     $expected->[0][0] = 'count'
.......
.......
# Looks like you failed 8 tests of 53.
dubious
        Test returned status 8 (wstat 2048, 0x800)
DIED. FAILED tests 24, 28, 32, 36, 40, 44, 48, 52
        Failed 8/53 tests, 84.91% okay

Thanks,
Raj

[Will Coleda]

Without code, it'll be hard to provide pointers; can you attach your
patch here or on the github issue tracker?

--
Will "Coke" Coleda

[Sitaram Chamarty]

erm, since you're on github, you should fork the project, make your
patch, and either send the maintainer a pull request (via github,
useful only if the maintainer is the only one you want to send it to)
or send the list a URL to your repo/branch.

then anyone can fetch that branch into their existing clones of ack,
which they presumably have, and look at it in context, maybe make
changes, etc.

sending patches by email also works, but github does help eliminate a
lot of that, really

[Raj A. Singh]

Thanks for inputs.

I have forked the project and checked in the changes. Please take a look -

http://github.com/dteklavya/ack/commit/0629c2c1ff2959cc9e053bbfe9c4529f14c0f1bd

Hope it fixes at least a part of the issue.

Thanks
Raj

Sitaram Chamarty wrote:

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "ack dev/users" group.
To post to this group, send email to ack-...@googlegroups.com
To unsubscribe from this group, send email to ack-users+...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/ack-users?hl=en
-~----------~----~----~----~------~----~------~--~---