review request

[Kyungyong Lee]

These days, there are some requests using Non ipop hostname on
grid-appliance. Instead they want to use globally-accessible hostname.
In order to support that I commented out /etc/ipop.vpn.config
"USE_IPOP_HOSTNAME" . After doing that it still uses IPOP hostname.
After debugging the system, I made some patches to make it work. Any
feedbacks or comments about possible side-effects would be
appreciated.

https://github.com/kyungyonglee/Grid-Appliance/commit/14a9e3d280cc818eaabd58f2753d8a7eae2e51c6

At the second patch (monitor.py), the monitor daemon periodically runs
ipop hostname setup script regardless of "USE_IPOP_HOSTNAME" setting.

At the first patch (groupvpn.sh), the ipop_hostname file at
"/etc/dhcp3/dhclient-exit-hooks.d" automatically runs always after
dhcp run. I added a script to delete "ipop_hostname" file when
"USE_IPOP_HOSTNAME" is not defined.

The third patch is for consistency to create IPOP hostname. Two
modules that creates IPOP hostname have different way of creating ipop
hostname (one with ".ipop" and one without ".ipop". I think it's
better to use ".ipop", and add it.)

Best,
Kyungyong

[Renato Figueiredo]

Thanks Kyungyong - I'm not sure I understand exactly the problem and solution, let's discuss at the p2p meeting.

--
You received this message because you are subscribed to the Google Groups "acis.p2p" group.
To post to this group, send email to aci...@googlegroups.com.
To unsubscribe from this group, send email to acisp2p+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/acisp2p?hl=en.

--
Dr. Renato J. Figueiredo
Associate Professor
ACIS Lab - ECE - University of Florida
UF Site Director, Center for Autonomic Computing
http://byron.acis.ufl.edu
ph: 352-392-6430

[Pierre St Juste]

Now that I understand what you are trying to do. I approve the code change.

Pierre St Juste