Issue 241 in accounts-sso: [libaccounts-glib] A small gobject introspection issue

[accoun...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 241 by coren...@elementaryos.org: [libaccounts-glib] A small
gobject introspection issue
https://code.google.com/p/accounts-sso/issues/detail?id=241

Here is an issue I found with the vala bindings, and a way to fix it :

in libaccounts-glib/ag-auth-data.c : Add (allow-none) to GVariant parameter
/**
* ag_auth_data_get_login_parameters:
* @self: the #AgAuthData.
* @extra_parameters: (transfer floating) (allow-none): a #GVariant
containing
* client-specific authentication parameters to be added to the returned
* dictionary.
*
* Gets the authentication parameters.
*
* Returns: (transfer none): a floating #GVariant of type
* %G_VARIANT_TYPE_VARDICT containing all the authentication parameters.
*
* Since: 1.4
*/

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[accoun...@googlecode.com]

Comment #1 on issue 241 by coren...@elementaryos.org: [libaccounts-glib] A

small gobject introspection issue
https://code.google.com/p/accounts-sso/issues/detail?id=241

Btw, the .vapi file included seems to be quite old as some trunk changes on
the introspection are not available inside it.

[accoun...@googlecode.com]

Updates:
Status: Started

Comment #2 on issue 241 by mardy.ta...@gmail.com: [libaccounts-glib] A

small gobject introspection issue
https://code.google.com/p/accounts-sso/issues/detail?id=241

Thanks Corentin for reporting this.

I've setup a branch with the proposed fix:
https://code.google.com/p/accounts-sso/source/detail?r=0db01d668249dc854a9ea916f9fb819487763e0c&name=issue-241&repo=libaccounts-glib

Could you please review it? I also regenerate the vapi file and got quite a
few differences from the existing file, but I chose to accept only those
updates which I'm rather confident won't break existing apps.
You might want to regenerate the file yourself and propose a patch, if you
think that I omitted some important changes.

[accoun...@googlecode.com]

Comment #3 on issue 241 by coren...@elementaryos.org: [libaccounts-glib] A

small gobject introspection issue
https://code.google.com/p/accounts-sso/issues/detail?id=241

Hmm, here is the change I also wanted to appear :

* in Ag.Account
public GLib.Variant get_variant (string key, out Ag.SettingSource?
source);
should become :
public unowned GLib.Variant get_variant (string key, out
Ag.SettingSource? source);

otherwise my app crashes when I use it…

* also in Ag.AccountService
public GLib.Variant get_variant (string key, out Ag.SettingSource?
source);
should become :
public unowned GLib.Variant get_variant (string key, out
Ag.SettingSource? source);

[accoun...@googlecode.com]

Comment #4 on issue 241 by mardy.ta...@gmail.com: [libaccounts-glib] A

small gobject introspection issue
https://code.google.com/p/accounts-sso/issues/detail?id=241

I now added these two, and also updated the error codes. Please review:

https://code.google.com/p/accounts-sso/source/detail?r=1225a0065da9422b5be31793d0c8fefdbf05bb71&name=issue-241&repo=libaccounts-glib#

[accoun...@googlecode.com]

Updates:
Status: Fixed

Comment #5 on issue 241 by mardy.ta...@gmail.com: [libaccounts-glib] A

small gobject introspection issue
https://code.google.com/p/accounts-sso/issues/detail?id=241

Merged!