Issue 248 in accounts-sso: [gsignond] Enable introspection

[accoun...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 248 by coren...@elementaryos.org: [gsignond] Enable introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Since it is possible to extend it with plugins, a good practice would be to
enable GObject introspection in order to use compatible introspected
languages (Vala for example).



--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[accoun...@googlecode.com]

Comment #1 on issue 248 by coren...@elementaryos.org: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Here is a patch enabling GObject Introspection and .vapi generation

Attachments:
0001-Enable-GObject-Introspection.patch 18.1 KB

[accoun...@googlecode.com]

Comment #2 on issue 248 by alex.kan...@gmail.com: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Uhm, I applied the patch, but nothing is generated. Did you forget to
include modifications to configure.ac and vala/Makefile.am?

[accoun...@googlecode.com]

Comment #3 on issue 248 by coren...@elementaryos.org: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Oops, it's my first time with git (I'm using Bazaar for the elementary
project)
I didn't know I had to add my changes :)
Anyway, here is a clone with the changes separated in commits.
https://code.google.com/r/corentin-introspection-fix/source/checkout

[accoun...@googlecode.com]

Comment #4 on issue 248 by alex.kan...@gmail.com: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Can you fix the warnings?

GISCAN gSignond-1.0.gir
gsignond-plugin-interface.c:366: Warning: gSignond:
gsignond_plugin_user_action_finished: unknown parameter 'ui_data' in
documentation comment, should be 'session_data'
gsignond-plugin-interface.c:383: Warning: gSignond:
gsignond_plugin_refresh: unknown parameter 'ui_data' in documentation
comment, should be 'session_data'
gsignond-security-context.c:127: Warning: gSignond:
gsignond_security_context_copy: return value: Invalid non-constant return
of bare structure or union; register as boxed type or (skip)
gsignond-security-context.c:80: Warning: gSignond:
gsignond_security_context_new: return value: Invalid non-constant return of
bare structure or union; register as boxed type or (skip)
gsignond-security-context.c:101: Warning: gSignond:
gsignond_security_context_new_from_values: return value: Invalid
non-constant return of bare structure or union; register as boxed type or
(skip)
gsignond-security-context.c:257: Warning: gSignond:
gsignond_security_context_from_variant: return value: Invalid non-constant
return of bare structure or union; register as boxed type or (skip)
gsignond-security-context.c:80: Warning: gSignond:
gsignond_security_context_new: return value: Invalid non-constant return of
bare structure or union; register as boxed type or (skip)
gsignond-security-context.c:101: Warning: gSignond:
gsignond_security_context_new_from_values: return value: Invalid
non-constant return of bare structure or union; register as boxed type or
(skip)
gsignond-security-context.c:257: Warning: gSignond:
gsignond_security_context_from_variant: return value: Invalid non-constant
return of bare structure or union; register as boxed type or (skip)
gsignond-session-data.c:156: Warning: gSignond:
gsignond_session_data_get_allowed_realms: return value: Invalid
non-constant return of bare structure or union; register as boxed type or
(skip)
gsignond-utils.c:311: Warning: gSignond: gsignond_variant_to_sequence:
return value: Invalid non-constant return of bare structure or union;
register as boxed type or (skip)
gsignond-utils.c:366: Warning: gSignond: gsignond_array_to_sequence: return
value: Invalid non-constant return of bare structure or union; register as
boxed type or (skip)
gsignond-utils.c:394: Warning: gSignond: gsignond_copy_array_to_sequence:
return value: Invalid non-constant return of bare structure or union;
register as boxed type or (skip)
gsignond-access-control-manager.c:463: Warning: gSignond:
gsignond_access_control_manager_security_context_of_keychain: return value:
Invalid non-constant return of bare structure or union; register as boxed
type or (skip)

[accoun...@googlecode.com]

Comment #6 on issue 248 by coren...@elementaryos.org: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Some warnings are here because GSignondSecurityContext is not a GObject
subclass and not even defined as a boxed type (needed for the
introspection). It would be a nice move to use G_DEFINE_BOXED_TYPE.
I also think that there are some problem by "subclassing" GList and
GHashTable by using a simple typedef and not by doing it as a real subclass
(for GSignondDictionary and GSignondSecurityContextList). If you can fix
it, that would allow us to not use a "gSignond-1.0-custom.vala" file
neither a "gSignond-1.0.metadata" file.

[accoun...@googlecode.com]

Comment #7 on issue 248 by alex.kan...@gmail.com: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Would you be interested in fixing those?

[accoun...@googlecode.com]

Comment #8 on issue 248 by coren...@elementaryos.org: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Okay, I've pushed some new commits to this branch.
The last 4 warnings are not blocking anything, so I think it's okay to let
it like this.

[accoun...@googlecode.com]

Comment #9 on issue 248 by alex.kan...@gmail.com: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Why did you add a '\n' in this commit?

https://code.google.com/r/corentin-introspection-fix/source/detail?r=c116addf8316a2465daf53e7aa644050d0318f17

Also, a better commit message would be nice - "Fixed compilation error" is
very vague.

[accoun...@googlecode.com]

Comment #10 on issue 248 by alex.kan...@gmail.com: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Please answer questions here, not on IRC :)

[accoun...@googlecode.com]

Comment #11 on issue 248 by tintou.n...@gmail.com: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Okay, sorry, I now have answered on the new bug tracker
https://gitlab.com/accounts-sso/accounts-sso/issues/1

[accoun...@googlecode.com]

Updates:
Status: Done

Comment #12 on issue 248 by alex.kan...@gmail.com: [gsignond] Enable
introspection
https://code.google.com/p/accounts-sso/issues/detail?id=248

Answered you there too, closing this issue.