Comment on revision r223e97eb9de7afd7699d5dadec6e0370617bff57 in gsignond.accounts-sso

[accoun...@googlecode.com]

Comment by alex.kan...@gmail.com:

Score: Negative

General Comment:
Attempting to load plugin '' should simply fail - I'd like to see why this
isn't so for you.

For more information:
https://code.google.com/p/accounts-sso/source/detail?r=223e97eb9de7afd7699d5dadec6e0370617bff57&repo=gsignond

[accoun...@googlecode.com]

Comment by alex.kan...@gmail.com:

Score: Negative

General Comment:

Imran, can you demonstrate or explain the issue that this patch is fixing?
I can't figure it out.

[accoun...@googlecode.com]

Comment by alex.kan...@gmail.com:

Score: Neutral

General Comment:
I've reverted this commit, for the following reasons:

1) I verified that all 4 situations are handled correctly on my machine.
Without this added check things fail gracefully as they should.
(loader_path is null, loader_path is "", plugin_type is NULL, plugin_type
is "").

2) If, however, on some other machine those 4 situations cause trouble,
then the problem is somewhere else in the code, so this fix is only masking
the real issue. Anything except empty plugin type shouldn't occur at all to
begin with; if it does, then it's a bug somewhere else.