Issue 247 in accounts-sso: [libgsignon-glib] enable .vapi file generation.

[accoun...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 247 by coren...@elementaryos.org: [libgsignon-glib] enable .vapi
file generation.
https://code.google.com/p/accounts-sso/issues/detail?id=247

As done in libaccounts-glib, the .vapi file should be generated at
compilation time and distributed with the libgsignon-glib-dev package in
order to ship the compatible .vapi with each version.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[accoun...@googlecode.com]

Comment #1 on issue 247 by alex.kan...@gmail.com: [libgsignon-glib]

enable .vapi file generation.
https://code.google.com/p/accounts-sso/issues/detail?id=247

Care to write a patch for this and #248?

[accoun...@googlecode.com]

Comment #2 on issue 247 by coren...@elementaryos.org: [libgsignon-glib]

enable .vapi file generation.
https://code.google.com/p/accounts-sso/issues/detail?id=247

Here is a fix for this:
* The .vapi file isn't generated at compilation time but everything is
done as it is in libaccounts-glib so it needs to be regenerated when the
API is changed.
* I fixed some introspection annotations in order to not manually patch
the .vapi file anymore (can maybe also fix things for other bindings)
* I also fixed the debian package to respect some Debian standards.

Attachments:
several_fixes.patch 27.0 KB

[accoun...@googlecode.com]

Comment #3 on issue 247 by alex.kan...@gmail.com: [libgsignon-glib]

enable .vapi file generation.
https://code.google.com/p/accounts-sso/issues/detail?id=247

If the .vapi file is generated and not handwritten, then maybe it should
happen at build time?

[accoun...@googlecode.com]

Comment #4 on issue 247 by coren...@elementaryos.org: [libgsignon-glib]

enable .vapi file generation.
https://code.google.com/p/accounts-sso/issues/detail?id=247

Here is a version that adds automatic .vapi generation.

Attachments:
fix_vapi2.patch 63.4 KB

[accoun...@googlecode.com]

Comment #5 on issue 247 by coren...@elementaryos.org: [libgsignon-glib]

enable .vapi file generation.
https://code.google.com/p/accounts-sso/issues/detail?id=247

Here is the latest version that I find much better than the previous ones.
The addition of a -custom.vala file is necessary because of the use of
GLib.List and GLib.HashMap subclasses.
So now the resulting .vapi looks exactly as the C API.

Attachments:
fix_vapi3.patch 59.6 KB

[accoun...@googlecode.com]

Comment #6 on issue 247 by alex.kan...@gmail.com: [libgsignon-glib]

enable .vapi file generation.
https://code.google.com/p/accounts-sso/issues/detail?id=247

Looks alright, but can you split this a little differently:

1) squash 1/3 together with 3/3 so that .vapi isn't added in one patch and
then removed in another patch.

2) all debian packaging fixes go into a single patch that comes after the
vapi generation patch

3) all documentation fixes go into a separate patch

[accoun...@googlecode.com]

Comment #7 on issue 247 by coren...@elementaryos.org: [libgsignon-glib]

enable .vapi file generation.
https://code.google.com/p/accounts-sso/issues/detail?id=247

Okay, I've separated the commits,
all changes are available here
https://code.google.com/r/corentin-vapi-fix/source/list

[accoun...@googlecode.com]

Comment #8 on issue 247 by alex.kan...@gmail.com: [libgsignon-glib]

enable .vapi file generation.
https://code.google.com/p/accounts-sso/issues/detail?id=247

I get the following warning:

GISCAN gSignon-1.0.gir
GICOMP gSignon-1.0.gir
VAPIGEN libgsignon-glib.vapi
gSignon-1.0.gir:1021.7-1021.68: warning: Signal `Signon.Identity.signout'
conflicts with method of the same name

[accoun...@googlecode.com]

Updates:
Status: Fixed

Comment #9 on issue 247 by alex.kan...@gmail.com: [libgsignon-glib]

enable .vapi file generation.
https://code.google.com/p/accounts-sso/issues/detail?id=247

"in current libgsignon-glib API, having a method with the same name as a
signal is not good for introspection"

Pushed the patches to devel.